Hi Andrew, for Visual C++ _isnan is defined in float.h and not in math.h and/or cmath. So this test is not valid for Visual C++ anyways, since _isnan isn't defined in either cmath or math.h. So it's maybe really the best to not run this test for Visual C++.
Regards, Werner Andrew Ross wrote: > Werner, > > Some history here. There were some unix platforms (AIX perhaps?) which at > the time had C++ implementations that were behind the times, so although > isnan was in math.h it was not in cmath. This test was to catch those. > For modernish compilers I would suspect math.h and cmath to be in sync. > We could extend the test to look for _isnan as well, consistent with the C > headers, or probably better to look for whatever version of the function > was found for C (either isnan or _isnan, depending on platform). > > Andrew > > On Mon, Mar 16, 2009 at 04:32:09PM +0100, Werner Smekal wrote: > >> Hi, >> >> we test in TestBrokenIsnanCXX.cmake if isnan is in either cmath or >> math.h - problem is Visual C++ doesn't pass this test, since the >> functions is called _isnan and not isnan. We test this already in >> plplot.cmake where we look for isnan or _isnan. The problem now is these >> are contradictory configurations since on one hand we have HAVE_ISNAN >> and _HAVE_ISNAN defined, on the other hand also BROKEN_ISNAN_CXX. In >> example 21 we incorrectly redeclare isnan which leads to warnings. >> >> For now if changed the cmake configuration so that >> TestBrokenIsnanCXX.cmake is only included for compilers other then >> Visual C++. This solves the problem for Visual C++ and doesn't harm any >> other compiler, but obviously we need to revisit this part of the cmake >> configuration. >> >> Regards, >> Werner >> >> -- >> Dr. Werner Smekal >> Institut fuer Allgemeine Physik >> Technische Universitaet Wien >> Wiedner Hauptstr 8-10 >> A-1040 Wien >> Austria >> DVR-Nr: 0005886 >> >> email: sme...@iap.tuwien.ac.at >> web: http://www.iap.tuwien.ac.at/~smekal >> phone: +43-(0)1-58801-13463 (office) >> +43-(0)1-58801-13469 (laboratory) >> fax: +43-(0)1-58801-13499 >> >> >> ------------------------------------------------------------------------------ >> Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are >> powering Web 2.0 with engaging, cross-platform capabilities. Quickly and >> easily build your RIAs with Flex Builder, the Eclipse(TM)based development >> software that enables intelligent coding and step-through debugging. >> Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com >> _______________________________________________ >> Plplot-devel mailing list >> Plplot-devel@lists.sourceforge.net >> https://lists.sourceforge.net/lists/listinfo/plplot-devel >> >> > > ------------------------------------------------------------------------------ > Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are > powering Web 2.0 with engaging, cross-platform capabilities. Quickly and > easily build your RIAs with Flex Builder, the Eclipse(TM)based development > software that enables intelligent coding and step-through debugging. > Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com > _______________________________________________ > Plplot-devel mailing list > Plplot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/plplot-devel > -- Dr. Werner Smekal Institut fuer Allgemeine Physik Technische Universitaet Wien Wiedner Hauptstr 8-10 A-1040 Wien Austria DVR-Nr: 0005886 email: sme...@iap.tuwien.ac.at web: http://www.iap.tuwien.ac.at/~smekal phone: +43-(0)1-58801-13463 (office) +43-(0)1-58801-13469 (laboratory) fax: +43-(0)1-58801-13499 ------------------------------------------------------------------------------ Apps built with the Adobe(R) Flex(R) framework and Flex Builder(TM) are powering Web 2.0 with engaging, cross-platform capabilities. Quickly and easily build your RIAs with Flex Builder, the Eclipse(TM)based development software that enables intelligent coding and step-through debugging. Download the free 60 day trial. http://p.sf.net/sfu/www-adobe-com _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
