On Sun, Aug 23, 2009 at 9:58 PM, Alan W. Irwin<ir...@beluga.phys.uvic.ca> wrote: > On 2009-08-23 12:31-0700 Alan W. Irwin wrote: > >> [...] I [suggest implementing] a static function cmap0_palette_read >> (consisting of >> most of the code in plspal0 now) that reads/checks the cmap0 palette files >> and which returns r,g,b,a data without messing with cmap0. plsscmap0n >> calls >> plcmap0_def which is updated (if imin <= imax) to call cmap0_palette_read >> to >> always fill in the r,g,b,a data from imin to imax with default colours. An >> updated version of plspal0 merely calls cmap0_palette_read, optionally >> calls >> plsscmap0n to establish a cmap0 of the right size, and copies the r,g,b,a >> data delivered by cmap0_palette_read to cmap0. >> >> Note with this approach we don't need logic to avoid potential recursion >> issues (since plsscmap0n does not call plspal0) and we go back to exactly >> the behaviour we had before for plsscmap0n but implemented using a pure >> palette file approach. >> > > Hez said: > >> I like this approach more than the updated patch I posted to the list. >> Your proposed approach sounds reasonably clean and straightforward >> Thank you for working on this! > > You are welcome. I have now finished the implementation as of revision > 10318. Could you please review my code changes since my C skills > (especially dealing with arrays in argument lists) are not as strong as I > would like. I have only done light testing with valgrind on one example so > far, but the results appear to be valgrind clean. The Ada color > initialization issue is solved as well by this change (only one example > tested so far).
Alan, I looked through the changes and they all seem fine to me. The examples test cleanly here for multiple output devices. Hez -- Hezekiah M. Carty Graduate Research Assistant University of Maryland Department of Atmospheric and Oceanic Science ------------------------------------------------------------------------------ Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day trial. Simplify your report design, integration and deployment - and focus on what you do best, core application coding. Discover what's new with Crystal Reports now. http://p.sf.net/sfu/bobj-july _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
