On Wed, Sep 23, 2009 at 10:09:57PM -0700, Alan Irwin wrote: > Here is what I have done with the style project today. > > I discovered that function argument list indentation was way too aggressive. > I corrected that and some documentation issues with uncrustify.cfg in > several commits today, but ultimately I also decided to deal with the ugly > line split issue. Andrew suggested off list we might want to go back to not > splitting extra-long lines automatically since it appeared that uncrustify > did that job in a poor way. That conservative approach appealed to me since > it gives us the opportunity to do the line splitting later by hand or by > uncrustify (if we can figure out the uncrustify configuration to make that > reliable and/or we use a later version of uncrustify that is not so > problematic with over-length line splitting). Accordingly, I made one > further change to uncrustify.cfg to not split extra long lines. In order to > restore those extra long lines I locally reverted all src changes back to > 10456 (using "svn merge --ignore-ancestor -r 10468:10456 .") then reapplied > uncrustify with the revised uncrustify.cfg where long line splitting had > been turned off. The result had substantially more satisfactory style than > revision 10468 so I committed the slight change to uncrustify.cfg and the > corresponding large changes to the code in src (as the result of not > splitting overlong lines) as of revision 10470. > > I have compared revisions 10470 and 10456 with the coloured differences > webpages I mentioned before (i.e., > http://plplot.svn.sourceforge.net/viewvc/plplot/trunk/src/<filename>?view=diff&r1=10470&r2=10456&diff_format=h) > where <filename> is plarc.c, etc. > > I am now in the process of looking at all *.h and *.c files in src using the > above URL template. At this point I have made it through plcont.c (in > alphabetical order), and so far I like everything I see. > > For example, the ltdl_win32.c "issue" I noticed before with blank line > removal after an else was due to my misunderstanding the coloured diff. > Sorry for that noise. > > Anyhow, it looks quite promising so far, and I will finish my evaluation of > the C src tomorrow after I get some sleep. I don't anticipate any further > changes on my part to uncrustify.cfg so over to you, Andrew, for looking > carefully at the C++ changes!
Alan, One consequence of your change is that long split lines for function definitions etc now indent at the beginning of the line rather than aligning on the brackets. Personally I don't like that. I'm trying to work out how to change this without breaking other things again. It's not entirely obvious. In the meantime I would prefer we don't propagate changes any further. It looks like line splitting is a can of worms. I've reverted to aligning function prototypes / definitions on the brackets, but left function calls for now since this was the source of some of the ugly long lines. Andrew ------------------------------------------------------------------------------ Come build with us! The BlackBerry® Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9-12, 2009. Register now! http://p.sf.net/sfu/devconf _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
