To Orion and Werner: I am switching this discussion to plplot_devel where it belongs. I also have a few comments below about how I assume we will adjust to CMake improvements/new releases in the future.
On 2009-10-28 11:12-0600 Orion Poplawski wrote: > > On Tue, October 27, 2009 2:15 pm, Werner Smekal wrote: >> Hi Orion, >> >> On Oct 27, 2009, at 6:53 PM, Orion Poplawski wrote: >> >>> On 10/26/2009 12:44 PM, Orion Poplawski wrote: >>>> in 2.8.0, FindwxWidgets.cmake strips -D from >>>> wxWidgets_DEFINITIONS. Why? >>>> >>> >>> Note that this is breaking previously working builds of plplot >>> because of the missing "-D". I don't see this being done in any >>> other module. >> >> I can't talk for Miguel, but these changes should not break your code, >> if you use the UsewxWidgets.cmake file which adds all the definitions, >> flags, etc. accordingly. We (for plplot) couldn't use this macro since >> we needed the definitions only for some source files, and since they >> were not placed in a separate directory, we just set the properties >> for the source files (without using usewxwidgets.cmake). This was >> maybe not the best thing to do, but for cmake 2.8.0 the plplot cmake >> build system is now broken (for the wxWidgets driver). >> >> Anyway, we need to change the plplot cmake build system for the >> wxWidgets part, since the changes Miguel applied fixed some problems >> for the MinGW and Visual C++ compiler toolset and I also plan to >> include FindwxWidgets.cmake to the plplot source, so that cmake 2.6.x >> users can also benefit from these changes as well. > > Okay. Let me know when a fix has been checked in to plplot and I'll test. The comments I have below are fairly obvious, but I thought this was a good opportunity to collect everything in one place. Orion, cmake-2.8 is currently just an early release candidate. The CMake developers have a track record of using many release candidates (usually more than 10) so it may be a large number of months before CMake-2.8.0 goes final. Also, it will probably take us a while after that finalization to make the PLplot build system compatible with 2.8.0. (You found one issue with wxwidgets in this release candidate, but there are probably other issues as well. This is so early in the 2.8.0 release process that I haven't tried it yet and I may wait quite a bit longer until I do so.) Anyhow, I suggest you stick with 2.6.x until 2.8.0 has been finalized and we have upgraded our build system to be compatible with it. N.B. "compatible with" means our build system will work with 2.8.0 without compromising its compatibility with 2.6.x. A topic that is related to CMake version compatiblity is our minimum release version. For now that is 2.6.0, but I plan to bump that to 2.6.4 once that version has propagated to most Linux distros. Also, I assume something like two years from now (depending on how quickly 2.8 gets released and how quickly that release propagates to Linux distros) we will drop 2.6.x completely and bump our minimum cmake version to 2.8.x. Meanwhile, what do we do if a cmake 2.8 module (which usually don't change that much from release candidates to the final version) is a huge improvement over what is available in 2.6.x? Then we follow what Werner plans to do with the 2.8 version of FindwxWidgets.cmake; put it in cmake/modules (which insures that version of the module is used rather than the 2.6 version that comes with CMake 2.6.x) and distribute it as part of PLplot until 2.8.x becomes our minimum version. In sum, everybody should stick with 2.6.x for now, and I completely approve of Werner's plans to use the 2.8 version of FindwxWidgets.cmake with CMake 2.6.x. We'll probably do this with other 2.8 modules as well if needed. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ Come build with us! The BlackBerry(R) Developer Conference in SF, CA is the only developer event you need to attend this year. Jumpstart your developing skills, take BlackBerry mobile applications to market and stay ahead of the curve. Join us from November 9 - 12, 2009. Register now! http://p.sf.net/sfu/devconference _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel