I decided to make the move from uncrustify 0.55 to 0.56 because
generally each new release of that software solves some bugs of the
previous version (and also gives more control of our source code
style).

Making this move generated a huge number of source-code style changes
(presumably as a result of bug fixes for uncrustify). Those consisted
of splitting off trailing comments (presumably when the line was too
long) and splitting up one-liner whiles, fors, else ifs, and ifs.  The
latter splitting of one-line ifs caused the vast majority (high 90's
percent) of the changes. (We had requested this before for uncrustify
0.55, but apparently it did not work consistently for that version
while it apparently does work for uncrustify 0.56.)

Since the change from uncrustify version 0.55 to 0.56 generated so
many different style changes I did a quick check to make sure

scripts/comprehensive_test.sh --do_nondynamic no --do_static no
--do_ctest no --do_build_tree_test no --do_traditional_tree_test no

produced good results with these style changes.  (That combination of
options is equivalent to only testing the shared library build in the
installed examples directory with the cmake-based build system both
noninteractively and interactively.)

All was well according to that test so I have committed all these
uncrustify 0.56 changes as revision 11176.  If you spot any style
problems in general or as a result of this revision, I urge you to
experiment with changing uncrustify.cfg (which is well commented)
and running

scripts/style_source.sh --diff |less

(which views the non-whitespace results of the uncrustify.cfg changes
without applying them) to see if you can improve our source-code style.

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state implementation
for stellar interiors (freeeos.sf.net); PLplot scientific plotting software
package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of
Linux Links project (loll.sf.net); and the Linux Brochure Project
(lbproject.sf.net).
__________________________

Linux-powered Science
__________________________

------------------------------------------------------------------------------
Start uncovering the many advantages of virtual appliances
and start using them to simplify application deployment and
accelerate your shift to cloud computing
http://p.sf.net/sfu/novell-sfdev2dev
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Reply via email to