On 2011-01-24 17:11-0800 Alan W. Irwin wrote: > [...]The current status is I have just finished all C changes (except for > implementation of the PL_POSITION_SUBPAGE bit logic) related to > pllegend. The C results look fine. However, in order to avoid core C > commits which break language components of PLplot, I am holding off > doing the commit until I can propagate everything to C++, f77, java, > ocaml, python, and octave bindings and examples. Once all those work, > then I plan to commit everything I have done up to that point [...].
DONE as of revision 11498 except for ocaml which I could not figure out. Because of that, this commit breaks the ocaml build so use -DENABLE_ocaml=OFF until it gets fixed. Hez, with regard to ocaml, I noticed that you treated pllegend very differently than plcolorbar in bindings/octave. Here are the grep results that show this: software@raven> grep -l pllegend * plplot.mli plplot_core.idl plplot_h plplot_impl.c software@raven> grep -l plcolorbar * plplot.mli plplot_h plplot_h.inc touchup.ml In fact it is worse than this because the mention of pllegend in plplot_h is commented out. One result of this is plplot_h.inc agrees with generated_plplot_h.inc (generated with the generate_plplot_h.inc target as a test), but neither file has a mention of pllegend in it while both do mention plcolorbar. Also, in plplot_impl.c, the opt parameter is processed in a way that I think must be incorrect with translate_legend_option. I suspect all this translate_legend_option logic can be removed now that there is a position argument with its own bit namespace for pllegend, but I am going to leave that to you since I really don't understand what is going on there, and also because I certainly don't understand why pllegend and plcolorbar are implemented so differently for the octave bindings. When pllegend for the octave bindings at least builds again, please signal that here so we don't get into the habit of setting -DENABLE_ocaml=OFF. > then > implement and commit the PL_POSITION_SUBPAGE logic, This is next on my agenda, but I don't think it will take long. > then (as soon as > Hez has finished with his own planned plcolorbar changes) implement > and commit full positioning logic in plcolorbar following what is done > for pllegend. Hez, please contact me off list about coordinating this. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ Special Offer-- Download ArcSight Logger for FREE (a $49 USD value)! Finally, a world-class log management solution at an even better price-free! Download using promo code Free_Logger_4_Dev2Dev. Offer expires February 28th, so secure your free ArcSight Logger TODAY! http://p.sf.net/sfu/arcsight-sfd2d _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
