On 2011-02-18 12:39+0100 Arjen Markus wrote: > Hi, > > I have had a look at the Tcl examples to get rid of the locally > defined values - we now have a namespace containing the definitions > of "symbols" such as PL_POSITION_LEFT and FACETED. I noticed that > quite a lot of the examples use "bare" expressions, like: > > $w cmd plarc 0.0 0.0 [expr 0.1 * $i] [expr 0.1 * $i] 0.0 360.0 > > This is not the idiomatic way in Tcl: the advice is to always brace > your expressions, so that the above becomes: > > $w cmd plarc 0.0 0.0 [expr {0.1 * $i}] [expr {0.1 * $i}] 0.0 360.0 > > The reason is that a braced expression needs to be parsed only once. > > My intention is to go through these examples and change the > unbraced expressions to braced expressions AND replace the locally > defined constants by the ones in the PLPLOT namespace that we now have. > > But should I commit these changes separately? Or does that not matter?
I don't think it matters that much. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); PLplot scientific plotting software package (plplot.org); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ The ultimate all-in-one performance toolkit: Intel(R) Parallel Studio XE: Pinpoint memory and threading errors before they happen. Find and fix more than 250 security defects in the development cycle. Locate bottlenecks in serial and parallel code that limit performance. http://p.sf.net/sfu/intel-dev2devfeb _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel