On 2011-10-08 17:57+0200 José Luis García Pallero wrote: > 2011/10/8 Andrew Ross <andrewr...@users.sourceforge.net>: >> On Fri, Oct 07, 2011 at 05:45:56PM -0700, Alan Irwin wrote: >>> On 2011-10-07 16:28-0700 Alan W. Irwin wrote: >>> >>>> Hi Andrew: >>>> >>>> Following Geoffrey's recent advice to test our software for standards >>>> compliancy, I tried the following: >>>> >>>> export CFLAGS='-O3 -fvisibility=hidden -std=c99 -pedantic' >>>> export 'CXXFLAGS='-O3 -fvisibility=hidden -std=c++98 -pedantic' >>>> export FFLAGS='-O3' > > In gcc documentation it can be readed about the -pedantic flag > (http://gcc.gnu.org/onlinedocs/gcc-4.6.1/gcc/Warning-Options.html#Warning-Options): > > "Some users try to use -pedantic to check programs for strict ISO C > conformance. They soon find that it does not do quite what they want: > it finds some non-ISO practices, but not all—only those for which ISO > C requires a diagnostic, and some others for which diagnostics have > been added." > > So I think that other warning flags should be added in order to check > the warning (not only warnongs concerning c99). First of all I think > that -Wall and -Wextra could be added. But -Wall and -Wextra do not > detect some warnings that I consider important, as type conversion > (useful to detect, for example, signed assignation to an unsigned > variable) or missing prototypes of functions. My list of flags for c99 > compilation is: > > CFLAGS='-O3 -std=c99 -pedantic -Wall -Wextra -Wmissing-prototypes > -Wstrict-prototypes -Wnested-externs -Wconversion -Wshadow -Wcast-qual > -Wcast-align -Wwrite-strings'
Hi José: Thanks very much for your advice which I think is quite good, but there will necessarily be a bit of delay adopting it. We are in the midst of a lot of testing looking primarily for any recently introduced regressions in preparation for a quick release to deal with the showstopper Windows build issues for 5.9.8 that have just been revealed to us. After that release we plan to deal with the many issues already revealed by "-std=c99 -pedantic". Once those are dealt with, I plan to take your advice and see what more is revealed by all the flags above. So I put the above flags in my testing scripts, but I commented them out for now. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ All of the data generated in your IT infrastructure is seriously valuable. Why? It contains a definitive record of application performance, security threats, fraudulent activity, and more. Splunk takes this data and makes sense of it. IT sense. And common sense. http://p.sf.net/sfu/splunk-d2dcopy2 _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
