Hi Andrew and Jerry: Andrew, would you please review my conclusions below and take appropriate action for svn trunk?
On 2012-05-11 00:43-0700 Jerry wrote: > 12121 Builds > 12122 Doesn't build > > http://plplot.svn.sourceforge.net/viewvc/plplot?view=revision&sortby=log&revision=12122 > tcl-related.cmake looks interesting. Jerry, your binary search to find the commit that screwed up the Tcl/Tk part of the PLplot build for you is extremely useful. Thanks! I have looked fairly carefully at that non-whitespace changes for that commit with svn diff -x -w --revision=12121:12122 |less A while ago I reverted the cmake/modules/wxwidgets.cmake part of revision 12122 since that caused (if I recall correctly) a run-time error on Linux. So the rest of that commit should be treated with caution as you have just discovered. Our Tk related bindings/examples depend on X (this is the reason our Tk stuff cannot currently be used on Windows). So I think we should revert (as Arjen also suggested) the revision=12122 change to cmake/modules/tcl-related.cmake, but I hope Andrew double-checks that conclusion. The following command run in examples/tk software@raven> grep -l "sin(" xtk*.c xtk01.c xtk02.c xtk04.c shows that all our xtk*.c examples depend directly on the math library so the revision=12122 change to examples/tk/Makefile.examples.in that drops -lm should be reverted. That leaves the cmake/modules/FindLTDL.cmake revision=12122 change as the only legitimate part (I think) to revision 12122, but I hope Andrew reviews that one as well since the rest of this commit is problematic. Jerry, would you be willing to do a similar binary search for the revision that caused the Qt4 issues for you? If so, I would disable Tcl with the appropriate cmake option (so the above commit issues don't matter for your test) and repeat the binary search from revision 12121 onward. Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
