Phil, (Caveat: I don't have windows to test on.)
This all looks fine. I think replacing char with TCHAR is the correct thing to do one Windows. I've gone ahead and committed this. Andrew On Fri, Aug 31, 2012 at 06:54:09AM -0700, phil rosenberg wrote: > Hi all > I've just been trying to build plplot with unicode under windows. I noticed > quite a few warnings with wingcc.c that didn't appear in the non-unicode > build. A quick check showed that this was due to passing char* strings to > unicode functions. Although these are only warnings I checked and they cause > corruption of the OS displayed strings (window title, menu items etc) so?I've > just been through and changed all apropriate chars to TCHARs and added _T() > macros as needed, there was also a conversion of one string from UTF-8 to > unicode and a #undef to add before a #define. > ? > I've tested compilation and build both with and without unicode selected and > checked with example x00 and all now seems fine. > ? > Patch attached > ? > Phil > ------------------------------------------------------------------------------ > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and > threat landscape has changed and how IT managers can respond. Discussions > will include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Plplot-devel mailing list > Plplot-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/plplot-devel ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
