Andrew,

Fine. Let me know if you have any questions on what I did/tried to do.

Steve

Andrew Ross wrote on 2013-06-05:
----------------
> 
> Steve,
> 
> This patch is pretty straightforward. I've applied it. I'll take a
> close look at the other patch later as it's a little more involved.
> 
> Regards
> 
> Andrew
> 
> 
> On Tuesday 04 Jun 2013 18:33:47 Alan W. Irwin wrote:
>> On 2013-05-27 12:55-0000 Schwartz, Steven J wrote:
>>> Dear plplot-devel,
>>> 
>>> I attach a patch to fix the mis-alignment of the major axes and
>>> grid
>> 
>> in the case of a time-axis ('d' option). This was due to different
>> algorithms being applied to determine the grid and tick location. In
>> essence, the grid didn't subtract off the start time.
>> 
>>> While fixing this, I also found a small bug in the tick routine
>>> for
>> 
>> the left y-axis again in the case of time ('d') option. This was due
>> to a vpwymi instead of vpwyma at this location. For reasons best
>> known to you, the tick routines work down the left axis and up the
>> right axis, so the two bits of code are different.
>> 
>>> I attach some code to test this, plus the before and after outputs.
>>> 
>>> Steve
>>> 
>>> PS I submitted a separate patch, also to plbox, last week. If it
>> 
>> would be helpful, I can generate a patch that combines both sets of
>> fixes. Both are patched against svn 12298.
>> 
>>> PPS in case someone is confused. My test rig plots y-axes as both
>>> a
>> 
>> float representation of the time (which starts at zero and runs
>> several days) and the plplot time (which starts at t=0 seconds,
>> corresponding to day 001 of the year). So the two plots don't appear
>> to have the same y-limits but are correct.
>> 
>>> PPPS I looked at the minor tick grid option ('h'), which works ok
>> 
>> but is absent in all cases unless the major grid is also requested.
>> I guess this is probably as intended, but does limit the ability to
>> use different line styles, thicknesses, and/or colours for the major
>> and minor grid.
>> 
>> Hi Steve:
>> 
>> I am up to my eyes in something else (The "Build Projects" project)
>> so I don't have time to look at your patches for probably several weeks.
>> Since nobody else has responded they are probably in the same
>> situation (one of the perils of an all-volunteer project).  However,
>> from your explanation of your first patch, it appears you are fixing
>> an area of PLplot (label exponents) that I have long thought was
>> problematic.  In fact, the situation has been so bad I have always
>> gone out of my way to use scaled or logarithmic variables to avoid
>> exponent labels as much as possible. So your first patch and also
>> your second patch to fix a misalignment issue sound useful.  So ping
>> us again in a couple of weeks if nobody has evaluated your patches
>> by then.
>> 
>> Alan
>> __________________________
>> Alan W. Irwin
>> 
>> Astronomical research affiliation with Department of Physics and
>> Astronomy, University of Victoria (astrowww.phys.uvic.ca).
>> 
>> Programming affiliations with the FreeEOS equation-of-state
>> implementation for stellar interiors (freeeos.sf.net); the Time
>> Ephemerides project (timeephem.sf.net); PLplot scientific plotting
>> software package (plplot.sf.net); the libLASi project
>> (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
>> and the Linux Brochure Project (lbproject.sf.net).
>> __________________________
>> 
>> Linux-powered Science
>> __________________________
>> 
>> --------------------------------------------------------------------
>> --
>> ------
>> -- How ServiceNow helps IT people transform IT departments:
>> 1. A cloud service to automate IT design, transition and operations 2.
>> Dashboards that offer high-level views of enterprise services 3. A
>> single system of record for all IT processes
>> http://p.sf.net/sfu/servicenow-d2d-j
>> _______________________________________________
>> Plplot-devel mailing list
>> Plplot-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/plplot-devel
--------------------------------------------------------------------
Professor Steven J Schwartz        Phone:  +44 (0)207 594 7660
Head, Space & Atmospheric Physics  Fax:    +44 (0)207 594 7772
The Blackett Laboratory            Email:  s.schwa...@imperial.ac.uk
Imperial College London            Office: Huxley 6M67A
London SW7 2AZ, UK                 Web:    www.sp.ph.ic.ac.uk/~sjs
--------------------------------------------------------------------



------------------------------------------------------------------------------
How ServiceNow helps IT people transform IT departments:
1. A cloud service to automate IT design, transition and operations
2. Dashboards that offer high-level views of enterprise services
3. A single system of record for all IT processes
http://p.sf.net/sfu/servicenow-d2d-j
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Reply via email to