On 08/23/2013 04:54 PM, Alan W. Irwin wrote:
> On 2013-08-23 15:08-0600 Orion Poplawski wrote:
>
>> So, I've updated plplot in (yet to be released) Fedora 20 to svn12479. This
>> contains the change of wid -> width for pen width. This is breaking my gdl
>> build because it is still trying to use wid() which is all of a sudden gone.
>> And now I have nothing like a version number change to key this on.
>>
>> So:
>>
>> - Is it intentional for plstream->wid() to be removed completely already?
>
> At the C level plwid is still available if the builder specifies
> -DPL_DEPRECATED=ON, but I suspect nobody has bothered to propagate
> that deprecated version to other languages. So IIRC we have a gradual
> change possible from plwid to plwidth for C, but an abrupt change for
> the bindings. That was not intentional, but it is also not a bad
> outcome since integer line widths are pretty old-fashioned and the fix
> is easy (see below).
>
>> - Time for a release?
>
> My opinion is this is long overdue. We still need to propagate the
> plcolorbar changes to the OCaml and Ada bindings and examples and
> document plcolorbar in doc/docbook/src/api.xml, but I think those
> relatively minor issues are all that is currently blocking us from a
> release.
>
>> - other suggestions?
>
> You are probably aware of this already, but the gdl breakage should be
> trivial to fix. Replace all instances of plstream->wid( integer
> width) with plstream->plwidth(floating width). One could test plplot
> to see if plwid or plwidth was available and key the change on that.
> However, I agree it would make life much easier for you and others to
> have a PLplot version number to key such a change.
>
> Thus, getting out a PLplot release out soon is important not only for
> this reason but many others.
Great.
FWIW - I'm doing something like the following in gdl for now:
iff -up gdl-0.9.3/CMakeLists.txt.plwidth gdl-0.9.3/CMakeLists.txt
--- gdl-0.9.3/CMakeLists.txt.plwidth 2013-08-27 16:55:33.806600443 -0600
+++ gdl-0.9.3/CMakeLists.txt 2013-08-27 16:55:36.589590528 -0600
@@ -23,6 +23,7 @@ include(CheckLibraryExists)
include(CheckFunctionExists)
include(CheckSymbolExists)
include(CheckCSourceRuns)
+include(CheckCXXSourceCompiles)
include(FindPkgConfig)
include(FindPackageHandleStandardArgs)
@@ -302,6 +303,18 @@ if(PLPLOT_FOUND)
message(STATUS "warning, due to old plplot library, [XYZ]TICKFORMAT
option for plot ax
is will not be supported.\n"
"you should upgrade to plplot version > 5.9.6")
endif(HAVE_PLPLOT_SLABELFUNC)
+ set(CMAKE_REQUIRED_INCLUDES "${PLPLOT_INCLUDE_DIR}")
+ set(CMAKE_REQUIRED_LIBRARIES "${PLPLOT_LIBRARIES}")
+ check_cxx_source_compiles("
+#include <plplot/plstream.h>
+int main(int argc, char **argv) {
+ plstream *p = new plstream();
+ PLFLT w = 0.5;
+ p->width(w);
+}" HAVE_PLPLOT_WIDTH)
+ if(HAVE_PLPLOT_WIDTH)
+ set(HAVE_PLPLOT_WIDTH 1)
+ endif(HAVE_PLPLOT_WIDTH)
check_library_exists("${PLPLOT_LIBRARIES}" plstrl ""
PLPLOT_PRIVATE_NOT_HIDDEN)
if(PLPLOT_PRIVATE_NOT_HIDDEN)
set(PLPLOT_PRIVATE_NOT_HIDDEN 1)
diff -up gdl-0.9.3/config.h.cmake.plwidth gdl-0.9.3/config.h.cmake
--- gdl-0.9.3/config.h.cmake.plwidth 2013-08-27 16:55:33.808600436 -0600
+++ gdl-0.9.3/config.h.cmake 2013-08-27 16:55:36.589590528 -0600
@@ -28,6 +28,7 @@
#cmakedefine HAVE_NEXTTOWARD 1
#cmakedefine HAVE_OLDPLPLOT 1
#cmakedefine HAVE_PLPLOT_SLABELFUNC 1
+#cmakedefine HAVE_PLPLOT_WIDTH 1
#cmakedefine PLPLOT_PRIVATE_NOT_HIDDEN 1
#cmakedefine PLPLOT_HAS_LEGEND
#ifndef HAVE_STDINT_H
Then keying off of HAVE_PLPLOT_WIDTH.
--
Orion Poplawski
Technical Manager 303-415-9701 x222
NWRA, Boulder/CoRA Office FAX: 303-415-9702
3380 Mitchell Lane [email protected]
Boulder, CO 80301 http://www.nwra.com
------------------------------------------------------------------------------
Learn the latest--Visual Studio 2012, SharePoint 2013, SQL 2012, more!
Discover the easy way to master current and previous Microsoft technologies
and advance your career. Get an incredible 1,500+ hours of step-by-step
tutorial videos with LearnDevNow. Subscribe today and save!
http://pubads.g.doubleclick.net/gampad/clk?id=58040911&iu=/4140/ostg.clktrk
_______________________________________________
Plplot-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/plplot-devel
