Arjen,

You only seem to have implement the rect option for the case with 1-d 
coordinate arrays. Unless there is a global transform set, the 1-d array case 
has to be cartesian coordinates. I think the 2-d coordinate array case is more 
important since this is what you would need to implement a more general 
coordinate transform. I know we don't test it, but for consistency the user 
should be able to use any combination of rect / 0-d, 1-d, 2-d coordinate 
arrays.

Cheers

Andrew


On Monday 09 Dec 2013 08:39:01 Arjen Markus wrote:
> Hi Alan,
> 
> the changes were required to be able to put the "rectangular" argument in
> the position corresponding to the C API. However, this did not require a
> change in example 22, because it is not using the version with the
> coordinate arrays.
> 
> Regards,
> 
> Arjen
> 
> > -----Original Message-----
> > From: Alan W. Irwin [mailto:[email protected]]
> > Sent: Saturday, December 07, 2013 6:18 PM
> > To: [email protected]
> > Cc: PLplot development list
> > Subject: Re: [Plplot-cvs] SF.net SVN: plplot:[12824] trunk/bindings/f95
> > 
> > On 2013-12-07 06:54-0000 [email protected] wrote:
> > > Revision: 12824
> > > 
> > >          http://sourceforge.net/p/plplot/code/12824
> > > 
> > > Author:   arjenmarkus
> > > Date:     2013-12-07 06:54:18 +0000 (Sat, 07 Dec 2013)
> > > Log Message:
> > > -----------
> > > Replace the optional "rectangular" argument to plshades by an overloaded
> > > function> 
> > so that it can be placed in the same position as in the corresponding C
> > function.> 
> > > Modified Paths:
> > > --------------
> > > 
> > >    trunk/bindings/f95/plplotf95.def
> > >    trunk/bindings/f95/plplotf95_ifort.def
> > >    trunk/bindings/f95/plplotf95_mingw.def
> > >    trunk/bindings/f95/sfstubs.f90
> > >    trunk/bindings/f95/sfstubsf95.f90
> > 
> > Hi Arjen:
> > 
> > It's been several hours since this commit, and nobody seems to have any
> > objection to it, but I have been reluctant to try it using "svn update"
> > because I am in the middle of a whole lot of tests, and I am concerned
> > this commit might break the examples/f95 tests.  I thought the reason you
> > created the overloaded function in the bindings was because it was
> > absolutely required in standard example 22 in order to get that example
> > to work, but this commit did not include anything from
> > examples/f95.   Or am I missing something and the overloaded function
> > is useful, but not actually required by example 22 in order to get it to
> > mimic the corresponding C example?
> > 
> > Alan
> > __________________________
> > Alan W. Irwin
> > 
> > Astronomical research affiliation with Department of Physics and
> > Astronomy,
> > University of Victoria (astrowww.phys.uvic.ca).
> > 
> > Programming affiliations with the FreeEOS equation-of-state implementation
> > for stellar interiors (freeeos.sf.net); the Time Ephemerides project
> > (timeephem.sf.net); PLplot scientific plotting software package
> > (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of
> > Linux Links project (loll.sf.net); and the Linux Brochure Project
> > (lbproject.sf.net).
> > __________________________
> > 
> > Linux-powered Science
> > __________________________
> 
> DISCLAIMER: This message is intended exclusively for the addressee(s) and
> may contain confidential and privileged information. If you are not the
> intended recipient please notify the sender immediately and destroy this
> message. Unauthorized use, disclosure or copying of this message is
> strictly prohibited. The foundation 'Stichting Deltares', which has its
> seat at Delft, The Netherlands, Commercial Registration Number 41146461, is
> not liable in any way whatsoever for consequences and/or damages resulting
> from the improper, incomplete and untimely dispatch, receipt and/or content
> of this e-mail.
> 
> ----------------------------------------------------------------------------
> -- Sponsored by Intel(R) XDK
> Develop, test and display web and hybrid apps with a single code base.
> Download it for free now!
> http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
> _______________________________________________
> Plplot-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/plplot-devel


------------------------------------------------------------------------------
Sponsored by Intel(R) XDK 
Develop, test and display web and hybrid apps with a single code base.
Download it for free now!
http://pubads.g.doubleclick.net/gampad/clk?id=111408631&iu=/4140/ostg.clktrk
_______________________________________________
Plplot-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Reply via email to