On 2014-10-06 11:56-0700 Alan W. Irwin wrote: > Hi Phil: > > I strongly recommend that you modify your recent changes so they only > apply for the MSVC platform [...]
@ Phil: Never mind, I did that myself with commit 5dd59cb. Please try git diff --ignore-all-space 5dd59cb^..5dd59cb to see the actual non white-space changes I did in this commit and also look at the 5dd59cb commit message for several important caveats. Please test my commit for the MSVC case to confirm I left in everything essential for that case (see caveats about the cd commands in the above commit message which may require further changes from you if the tcldir variable is being set to the wrong value for MSVC). Also, please test the Cygwin platform with the Cygwin version of CMake (if an incorrect CMake version was your prior issue) to see if you can confirm the good results that Arjen obtained before for that platform for the tcl case. And similarly test the MSYS platform (this time for the native Windows version of CMake) if you have time. @Arjen: Please test Tcl on both the Cygwin and MSYS platforms to make sure no build-system regressions have crept in since your last successful tests on those platforms. @Both of you: I prefer not to do comprehensive MSYS tests very often because they take roughly 20 times longer (i.e., several days rather than several hours) to do on the Wine version of Windows I have access to compared to the Microsoft version of Windows that you guys have access to. However, the last comprehensive tests I did on Wine were perfect, and I don't think anything bad has been introduced into the build system (at least in its current state for commit 5dd59cb) for the MSYS platform since that success. So the tests I have requested from you guys for MSYS should also be perfect if you have no blanks in paths. @Phil: note that my test of a blank in the build-tree path for the "test_tcl" target did not work on Linux (see above commit message), but I assume that is because you are still working through all the blank-in-build-tree-pathname issues for the test_tcl target case (which tests everything to do with Tcl). Alan __________________________ Alan W. Irwin Astronomical research affiliation with Department of Physics and Astronomy, University of Victoria (astrowww.phys.uvic.ca). Programming affiliations with the FreeEOS equation-of-state implementation for stellar interiors (freeeos.sf.net); the Time Ephemerides project (timeephem.sf.net); PLplot scientific plotting software package (plplot.sf.net); the libLASi project (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); and the Linux Brochure Project (lbproject.sf.net). __________________________ Linux-powered Science __________________________ ------------------------------------------------------------------------------ Meet PCI DSS 3.0 Compliance Requirements with EventLog Analyzer Achieve PCI DSS 3.0 Compliant Status with Out-of-the-box PCI DSS Reports Are you Audit-Ready for PCI DSS 3.0 Compliance? Download White paper Comply to PCI DSS 3.0 Requirement 10 and 11.5 with EventLog Analyzer http://pubads.g.doubleclick.net/gampad/clk?id=154622311&iu=/4140/ostg.clktrk _______________________________________________ Plplot-devel mailing list Plplot-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-devel
