Hi AlanThe points 1 and 3 that you mentioned have been addressed by my latest 
commit. Feel free to comment on or change the notice in the the 
README.developers file if you think it is not suitable.
Regarding the use or the cxx_pltr family of classes, these are a totally 
separate object oriented method of defining transforms which provide more of an 
abstracted interface. This extra level of abstraction gives extra flexibility. 
I'm sure Andrew can comment more, but I don't see this as something that should 
be touched by these modifications which just give what is essentially a mirror 
of the C functions.
Phil 
       From: Alan W. Irwin <ir...@beluga.phys.uvic.ca>
 To: phil rosenberg <philip_rosenb...@yahoo.com> 
Cc: PLplot development list <Plplot-devel@lists.sourceforge.net> 
 Sent: Monday, 27 October 2014, 20:20
 Subject: Re: [Plplot-devel] Why is the set_stream() call commented 
outforplstream::fill, etc.
   
On 2014-10-27 12:47-0000 phil rosenberg wrote:

> Hi AlanThe fixes are now committed.

Hi Phil:

Your docbook changes validated and built without issues. There were a
couple of misspellings.  Since I am a pretty lousy speller myself,
that inspired me to check and fix all our docbook src for
misspelling's using ispell which is a pretty useful application.  (See
commit 4e6c0e3.)

> Hopefully this issue is all sorted and you can undo the
linkage changes you made to temporarily fix the building of the
examples.

See commit 254a9b9 where your changes combined with reverting my previous
temporary fix was tested successfully with the test_diff_psc
target.

So it appears your changes are a success, and thanks very much
for this effort so far.

However, there is a bit more to do to completely finish this topic.

(1) This is not a minor change so please add a prominent (i.e., in the
announcements section) warning about the backwards-incompatible C++
API changes you have done in README.release.  For example, this change
requires all C++ users of plshade, plshades, plcont, imagefr, and vect
to change their source code and rebuild.  You should warn them of that
and also state in the warning what source code changes will be
required.

(2) The special example examples/c/x01cc.cc calls a special overloaded
version of shade using a callback argument of &tr. But previously
there is a direct call to cxx_pltr2 tr( xg, yg ) which presumably has
something to do with the cxx_pltr2 class.  I must admit I don't know
what is going on with that because of my lack of C++ skills, but my
suspicion is that direct call is an indirect way to define tr since I
can find no definition of tr anywhere else. Can some or all of this
special case be handled the way you handle other shade callbacks?

(3) fill_callback is defined in examples/c++/plstream.cc but
"fill_callback" is referred to nowhere else in bindings or examples.
"fill_callback" was created with your last commit, and I suspect that
was a leftover from a different approach that you will want to remove.



Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________


  
------------------------------------------------------------------------------
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Reply via email to