On 2015-05-09 08:43-0500 Aaron Hexamer wrote:

Alan

Thanks for the explanation.  I've attached a patch [to fix the
memqt-only case], but I must caveat that
it's only been tested in the limited context of my application.  In
particular I'm concerned that the code I stripped out of qt.cmake is there
for some good reason, but I can't figure out what that is.

Hi Aaron:

As stated on plplot-general, I have moved this topic to the
plplot-devel mailing list in case there is any further posts in this
thread after this one.  I also encourage you to subscribe to
plplot-devel.

I implemented the logic in qt.cmake some time ago that your commit
removes, but I agree with you there is not much point to it so I think
your removal was correct. Furthermore, I removed one other nonsensical
piece of logic in that file and did a few other small changes in
addition to yours.

Thanks for formatting your patch with git format-patch.
I made that commit on a topic branch using "git am" and then amended that
commit further with git commit --amend before pushing it.

Those further (small) changes were in the following files:

#       modified:   cmake/modules/drivers-init.cmake
#       modified:   cmake/modules/qt.cmake
#       modified:   examples/c++/CMakeLists.txt

They identified memqt as a memory device (as opposed to an external
device which is good for human interpretation but makes no practical
difference to the build system) and consistently used PLD_extqt rather
than ENABLE_qt to identify when the pyqt4 bindings should be implemented
and the qt_example application built.

I found ways to test both extqt alone and memqt alone, and those
results were satisfactory.  See the commit message for commit id
7f9ba09 for more details of those tests.

Please try this commit and let me know whether it satisfies
your needs.

Alan
__________________________
Alan W. Irwin

Astronomical research affiliation with Department of Physics and Astronomy,
University of Victoria (astrowww.phys.uvic.ca).

Programming affiliations with the FreeEOS equation-of-state
implementation for stellar interiors (freeeos.sf.net); the Time
Ephemerides project (timeephem.sf.net); PLplot scientific plotting
software package (plplot.sf.net); the libLASi project
(unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
and the Linux Brochure Project (lbproject.sf.net).
__________________________

Linux-powered Science
__________________________

Attachment: 0001-fix-configuration-for-case-where-memqt-is-the-only-Q.PATCH
Description: Binary data

------------------------------------------------------------------------------
One dashboard for servers and applications across Physical-Virtual-Cloud 
Widest out-of-the-box monitoring support with 50+ applications
Performance metrics, stats and reports that give you Actionable Insights
Deep dive visibility with transaction tracing using APM Insight.
http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel

Reply via email to