There's a small change that must be done in my 2nd patch
here
bool wxPLplotwindow<WXWINDOW>::Show(bool show)
{
wxLogDebug("wxPLplotwindow::Show");
CreateStream();
WXWINDOW::Show(show);
}
it should be instead
return WXWINDOW::Show(show);
gcc let me get away with it, but it's an error in Visual Studio
-Pedro
----- Original Message -----
From: "Pedro Vicente" <pedro.vice...@space-research.org>
To: "Alan W. Irwin" <ir...@beluga.phys.uvic.ca>
Cc: "PLplot development list" <plplot-devel@lists.sourceforge.net>
Sent: Friday, December 16, 2016 1:30 PM
Subject: Re: [Plplot-devel] The pls NULL fix for some Linux platforms
> Hi Alan
>
> the patch with the 2nd commit with fix is attached
> -Pedro
>
>
> On 2016-12-15 20:14, Alan W. Irwin wrote:
>> On 2016-12-15 18:39-0500 Pedro Vicente wrote:
>>
>>> I did what the README file said and here it is my first patch
>>> attached:-)
>>>
>>> what it has it's *just* some print messages (not my fix yet) so that
>>> you and Phil could get a better idea of the bug
>>>
>>> I have
>>>
>>> 17:57:49: Debug: wxPLplotwindow::wxPLplotwindow
>>> 17:57:49: Debug: frame->Create
>>> 17:57:49: Debug: pls NULL
>>> 17:57:49: Debug: wxPLplotwindow::RenewPlot
>>> 17:57:49: Debug: wxPLplotwindow::OnCreate
>>> 17:57:49: Debug: wxPLplotwindow::RenewPlot
>>>
>>> so this clearly shows that the stream is NULL on my linux build
>>
>> Hi Pedro:
>>
>> Your commit applied cleanly here on a topic branch. And I like the
>> fact you have a separate commit for the debugging output and
>> later you will follow up with your commit with your actual
>> fix (for VirtualBox'd Linux platforms).
>>
>> I do have a strong suggestion that the style of your commit message
>> needs to be reformatted.
>>
>> So instead of saying
>>
>> add debug messages that show sequence of events for a bug that
>> happens
>> on linux with wxwidgets3.0 installed from packages cause is that
>> frame->Create does not trigger a OnCreate() event before the PLot()
>> call
>>
>> in your very first paragraph, you should reformat that as follows:
>>
>> wxwidgets binding: insert debug messages
>> <paragraph break>
>> Add debug messages that show sequence of events for a bug that
>> happens
>> on linux with wxwidgets3.0 installed from packages. The cause (at
>> least on VirtualBox Linux platforms) is that frame->Create does not
>> trigger an OnCreate() event before the PLot() call as shown by the
>> following debug messages when the test_wxPLplotDemo target is built
>> on a VirtualBox'd Linux system.
>> <paragraph break>
>> 17:57:49: Debug: wxPLplotwindow::wxPLplotwindow
>> 17:57:49: Debug: frame->Create
>> 17:57:49: Debug: pls NULL
>> 17:57:49: Debug: wxPLplotwindow::RenewPlot
>> 17:57:49: Debug: wxPLplotwindow::OnCreate
>> 17:57:49: Debug: wxPLplotwindow::RenewPlot
>>
>> That first very short (one line) paragraph is important (as I also
>> noted in README.developers) because that short summary of
>> the commit is used in all sorts of places within git.
>>
>> IF you haven't done any further commits,
>> you can change to this new style by simply using
>>
>> git commit --amend
>>
>> which allows you to amend your current commit message if you have
>> nothing staged yet for your next commit.
>>
>> Or I can do a similar commit amend here (but I prefer you do it for
>> the
>> practice).
>>
>> @Phil:
>>
>> I implemented the current form of Pedro's first commit here as
>> follows:
>>
>> First update local git master to latest git master from SF as per
>> usual. Then
>>
>> # If not there already
>> git checkout master
>> # Always develop on topic branches starting from fresh master
>> git checkout -b wxwidgets_fixes
>> # Create Pedro's commit on that new branch
>> git am
>>
>> </home/irwin/Pedro.Vincente/20161215/fix/0001-add-debug-messages-that-show-sequence-of-events-for-.patch
>>
>> That commit applied cleanly (except for a minor warning about a
>> trailing whitespace issue).
>>
>> @Pedro:
>>
>> I then got the following result here from building test_wxPLplotDemo
>>
>> 16:37:03: Debug: wxPLplotwindow::wxPLplotwindow
>> 16:37:03: Debug: frame->Create
>> 16:37:03: Debug: wxPLplotwindow::RenewPlot
>> 16:37:03: Debug: wxPLplotwindow::RenewPlot
>> 16:37:03: Debug: wxPLplotwindow::OnCreate
>> 16:37:03: Debug: wxPLplotwindow::RenewPlot
>> 16:37:03: Debug: Plot()
>> 16:37:03: Debug: wxPLplotwindow::RenewPlot
>> PLMemoryMap::close: just entering close
>> [100%] Built target test_wxPLplotDemo
>>
>> which continues to show non-NULL pls here.
>>
>> Nevertheless from my perspective as release manager we want to
>> accommodate all platforms including VirtualBox ones (even if we are
>> missing something now, as Phil suggested, to explain this difference
>> between those platforms and ordinary Linux).
>>
>> So please go ahead and send me both commits (the first one amended as
>> above, and your next commit to take care of this pls NULL issue on
>> VirtualBox'd Linux platforms). And then assuming there are no
>> problems
>> here due to these two commits, I will merge both commits to SF master
>> unless I hear differently from Phil between now and then.
>>
>> Alan
>> __________________________
>> Alan W. Irwin
>>
>> Astronomical research affiliation with Department of Physics and
>> Astronomy,
>> University of Victoria (astrowww.phys.uvic.ca).
>>
>> Programming affiliations with the FreeEOS equation-of-state
>> implementation for stellar interiors (freeeos.sf.net); the Time
>> Ephemerides project (timeephem.sf.net); PLplot scientific plotting
>> software package (plplot.sf.net); the libLASi project
>> (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net);
>> and the Linux Brochure Project (lbproject.sf.net).
>> __________________________
>>
>> Linux-powered Science
>> __________________________
>
> --
> Pedro Vicente
> pedro.vice...@space-research.org
> http://www.space-research.org/
--------------------------------------------------------------------------------
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
--------------------------------------------------------------------------------
> _______________________________________________
> Plplot-devel mailing list
> Plplot-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/plplot-devel
>
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel
