Hi Phil,
On 28.9.17 22:31, Phil Rosenberg wrote:
I have just fixed the map plots. Apologies that this has taken
sooooooo long. The changes have just been pushed to the development
version and have been checked on my windows machine. Note that you
were correct also about there being an issue with using plmapfill. It
turned out that the type specified in the shapefile was overriding the
render type specified by the user.
Thanks for the fixes.
I just tested with HEAD and the polygon code no longer crashes.
Next I wanted to test with a map with lines and no fill. Unfortunately
plmapline also draws filled polygons. I did this test with the same
shapefiles [1] as the original test.
I assume it is caused by the code: src/plmap.c:324
if ( shapetype == SHPT_NULL )
{
shapetype = fileShapeType;
}
The attached patch lets plmapline draw lines instead of filled polygons.
I tested HEAD+patch and the coastal lines no longer disappear, so that
issue is also fixed.
I will do more testing next week, thanks again for the fixes.
[1]
http://www.naturalearthdata.com/http//www.naturalearthdata.com/download/50m/cultural/ne_50m_admin_0_countries_lakes.zip
Regards,
Mark de Wever
diff --git a/src/plmap.c b/src/plmap.c
index 58d359a99..694e23fce 100644
--- a/src/plmap.c
+++ b/src/plmap.c
@@ -596,7 +596,7 @@ plmapline( PLMAPFORM_callback mapform, PLCHAR_VECTOR name,
PLINT_VECTOR plotentries, PLINT nplotentries )
{
#ifdef HAVE_SHAPELIB
- drawmap( mapform, name, 0.0, 0.0, SHPT_NULL, 0.0, "", minx, maxx,
+ drawmap( mapform, name, 0.0, 0.0, SHPT_ARC, 0.0, "", minx, maxx,
miny, maxy, plotentries, nplotentries );
#else
plwarn( "plmapline is a no-op because shapelib is not available." );
------------------------------------------------------------------------------
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
_______________________________________________
Plplot-devel mailing list
Plplot-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/plplot-devel
