Hi Alan,
Many thanks for your quick fix! It works fine: the pkg-config files are working fine now. I would like to renew my request for a PLplot bug fix release though. Currently, 3 patches need to be applied to get the 5.11.1 compiling and working properly with the latest CMake. Also, this kind of bug would have been detected easily with a continuous integration setup: that’s how I discovered this particular bug in fact. Best, Tom > On 20 Nov 2016, at 00:46, Alan W. Irwin <ir...@beluga.phys.uvic.ca> wrote: > > On 2016-11-15 03:37-0800 Alan W. Irwin wrote: > >> On 2016-11-15 09:38-0000 Tom Schoonjans wrote: >> >>> Hi all, >>> >>> >>> I would like to report that the last official CMake release produces buggy >>> and therefore useless PLplot pkg-config files. >>> >> >> Thanks, Tom, for your report of this issue. Is this report for the >> official release of PLplot-5.11.1 or for the much later git master >> branch version which is about to released as PLplot-5.12.0? The >> reason I ask is it is possible whatever the problem is has been fixed >> in the git version. But if you report that is not the case, I promise >> to take a look at the issue (although likely late this week after I >> have dealt with some other PLplot issues that are currently on my >> plate). > > Hi Tom: > > I have now dealt with this issue (see commit db396b9). Please look at > that commit message for the detailed explanation. Bottom line though, > is we rely on sharp-eyed users or developers to pay close attention > whenever there is a CMP0054 related warning because it is normally a > sure sign that our CMake code is no longer working correctly (e.g., > this case) because of a subtle name clash. In this case the variable > called "c" was defined by CMake-3.7.0, and that nameclashed with our > previous logic > > if(BINDING STREQUAL "c") > > As soon as we adopt a minimum version of CMake that is not in the dark > ages, CMP0054 will automatically take on the NEW behaviour (anything > in quotes within an if statement will not be dereferenced) and these > nasty and completely unexpected nameclashes will be a thing of the > past! > > Alan > __________________________ > Alan W. Irwin > > Astronomical research affiliation with Department of Physics and Astronomy, > University of Victoria (astrowww.phys.uvic.ca). > > Programming affiliations with the FreeEOS equation-of-state > implementation for stellar interiors (freeeos.sf.net); the Time > Ephemerides project (timeephem.sf.net); PLplot scientific plotting > software package (plplot.sf.net); the libLASi project > (unifont.org/lasi); the Loads of Linux Links project (loll.sf.net); > and the Linux Brochure Project (lbproject.sf.net). > __________________________ > > Linux-powered Science > __________________________
------------------------------------------------------------------------------
_______________________________________________ Plplot-general mailing list Plplot-general@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/plplot-general
