On Mon, Oct 29, 2001, MATSUMOTO Masakazu wrote:
> Here is the patch for i18n branch to enable search.
Cool!
> Two files are modified.
I will take a look at the changes to the search function and also take
a closer look at *all* the changes in the i18n branch.
> * paragraph.c: WriteLine(), DrawParagraph()
> Tricky "minus 1" operation to patternCount is abolished by
> reordering conditions in the main loop of WriteLine().
The handling of the search result (i.e. jumping to the correct position
in the page) is a very ugly part of the viewer's source code, so any
changes to clean that up are appreciated (most of the search stuff is
the worst kind of patch work I have ever created, so I guess we
eventually have to clean that up :)
However, the changes you made will break the word wrapping, e.g. the
first line of text in the User's Guide is displayed like this with a
viewer from the main trunk (and also with a i18n version without the
patch),
A free multiplatform tool for reading
web pages on Palm OS(r) handhelds
With the i18n patched version it instead looks like this,
A free multiplatform tool for readin
g
web pages on Palm OS(r) handhelds
^
|
The 'm' is also corrupt with several missing pixels (usually that
indicates that the position of the text has been messed up somehow).
/Mike
