Documentation in CLI.md:
musicartistinfo lyrics [artist:abba title:waterloo | album_id:123 |
url:]
uses track_id, not album_id.

Thanks. That's an easy fix :-)

Also, the resulting behaviour depending on which parameter is set is
very confusing to me. It seems
track_id (or url) and no artist/title: only local lyrics
track_id and artist/title: cached lyrics (if available) or local lyrics
(if not). If both fail, finally online search
artist/title and no track_id: cached lyrics (if available) or online
search (if not)
Is this correct?

Good catch! There's indeed no code getting getting artist/title from the track in case of a track_id only. I'll fix that.

Suggestions for improvements:
albumcovers returns image size as one value (WxH or W or H). While WxH
can be split into W/H, there is no way of knowing if a single value is W
or H. Returning 2 values (e.g. size_w and size_h) would solve this.

artistphotos doesn't return image size, although they seem to be
avilable in ArtistInfo._getArtistPhotos(). Returning them as
size_w/size_h would be quite useful for client apps

I can add width/height. Alas: I wouldn't get them in all cases. You can't rely on them being around.

Thanks for your feedback!

--

Michael
_______________________________________________
plugins mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/plugins

Reply via email to