mamema wrote: 
> which indexes do you mean? Except those from the temp table, we've
> discussed in the Dev Area, all needed indexes are there.
> Trackstat creates and deletes indexes and both is working.

I read the code a bit fast, the naming is the same so there aren’t any
duplicated indexes, I just wonder why this plugin creates indexes that
TrackStat already have created, gives me a feeling something doesnt work
properly in TrackStat.

The following should be created by TrackStat:

Code:
--------------------
    
  CREATE INDEX IF NOT EXISTS persistentdb.tsurlIndex on track_statistics (url);
  CREATE INDEX IF NOT EXISTS persistentdb.tsurlmd5Index on track_statistics 
(urlmd5);
  CREATE INDEX IF NOT EXISTS persistentdb.tsmusicbrainzIndex on 
track_statistics (musicbrainz_id);
  CREATE INDEX IF NOT EXISTS persistentdb.tshurlIndex on track_history (url);
  CREATE INDEX IF NOT EXISTS persistentdb.tshmusicbrainzIndex on track_history 
(musicbrainz_id);
  CREATE INDEX IF NOT EXISTS trackStatMBIndex on tracks (musicbrainz_id)
  
--------------------


The following is created by this plugin (if I read the code properly)

Code:
--------------------
    
  CREATE INDEX IF NOT EXISTS persistentdb.tsurlIndex on track_statistics (url)
  CREATE INDEX IF NOT EXISTS persistentdb.tsurlmd5Index on track_statistics 
(urlmd5)
  CREATE INDEX IF NOT EXISTS persistentdb.tsmusicbrainzIndex on 
track_statistics (musicbrainz_id)
  CREATE INDEX IF NOT EXISTS persistentdb.tshurlIndex on track_history (url)
  CREATE INDEX IF NOT EXISTS persistentdb.tshmusicbrainzIndex on track_history 
(musicbrainz_id)
  CREATE INDEX IF NOT EXISTS trackStatMBIndex on tracks (musicbrainz_id)
  CREATE INDEX IF NOT EXISTS persistentdb.tsurlmdmbIndex on 
track_history(urlmd5,musicbrainz_id)
  CREATE INDEX IF NOT EXISTS persistentdb.tsurlmdmbStatIndex on 
track_statistics(urlmd5,musicbrainz_id)
  CREATE INDEX IF NOT EXISTS trackStatMBURLIndex on tracks 
(musicbrainz_id,urlmd5,url)
  
--------------------


If the extra 3 indexes this plugin creates improve TrackStat performance
it would be great if someone have the time to release a new version of
TrackStat that includes them.

And the tracks table trackStatMBIndex index should really be created by
core LMS if it helps performance since core LMS owns the tracks table.



Erland Isaksson ('My homepage' (http://erland.isaksson.info))
Developer of 'many plugins/applets'
(https://wiki.slimdevices.com/index.php/User_Erland.html)
*Starting with LMS 8.0 I no longer support my plugins/applets* ('see
here for more information'
(https://forums.slimdevices.com/showthread.php?49483-Announce-New-versions-of-erlands-plugins&p=998836&viewfull=1#post998836)
)
------------------------------------------------------------------------
erland's Profile: http://forums.slimdevices.com/member.php?userid=3124
View this thread: http://forums.slimdevices.com/showthread.php?t=114067

_______________________________________________
plugins mailing list
[email protected]
http://lists.slimdevices.com/mailman/listinfo/plugins

Reply via email to