bugs.slimdevices.com seems to be down, but I opened a bug on this in
October:

Converting some old code, SC7 complained about strings.txt for two
plugins. The
problem seemed to be that the plugins were originally written on
Windows, so
when I copied Plugin.pm and pared it down to make strings.txt, my
strings.txt
files had DOS line endings. Slim/Utils/Strings.pm uses chomp() to
remove line
endings (I'm not a fan of chomp) which leaves DOS \r at the end of
strings when
SC7 runs on Unix. I'd suggest something like the following (untested; I
just
used dos2unix to fix my files) -- with strings moving out of .pm files
and
developers on multiple platforms, SC7 shouldn't be so picky.


Code:
--------------------
    
  --- Slim/Utils/Strings.pm       (revision 13905)
  +++ Slim/Utils/Strings.pm       (working copy)
  @@ -270,7 +270,7 @@
  LINE: for my $line (split('\n', $$text)) {
  
  $ln++;
  -               chomp($line);
  +               $line =~ s/[\r\n]//g;
  
  next if $line =~ /^#/;
  next if $line !~ /\S/;
  
--------------------


-- 
peterw

http://www.tux.org/~peterw/
free plugins: http://www.tux.org/~peterw/#slim
AllQuiet BlankSaver BottleRocket FuzzyTime SaverSwitcher SleepFade
StatusFirst VolumeLock
------------------------------------------------------------------------
peterw's Profile: http://forums.slimdevices.com/member.php?userid=2107
View this thread: http://forums.slimdevices.com/showthread.php?t=40933

_______________________________________________
plugins mailing list
[email protected]
http://lists.slimdevices.com/lists/listinfo/plugins

Reply via email to