>The code does check whether there's an empty value >or not. Thus it should not display a link when an empty value is defined. >Did you file a bug report? > No. As it was my mistake when I created the plugin, I've just removed the line from the file (until the point in time where I actually get round to figuring out how to add a settings page to my plugin!).
>We either would have to remove them from the plugins page or continue with >duplicates for >the same reason I mentioned above: we also have per player settings. > I didn't understand the issue with per-player settings, as I thought they only appeared on the player settings page, and never affected what is displayed in the plugins settings tabs - I thought that would only link to server settings for the plugin if there were any. But I see your point, as I now understand there can be player settings that the plugin settings link can link to. I think it's that that causes the problems, and why they have to be duplicated in Advanced (in case there is a plugin where the plugin settings links to player prefs, but there could also be server prefs too - don't think there are any of those, but suppose it could happen). Things do tend to start going a bit wrong when you go to server settings > plugins > settings that link to player settings. In other skins you select a player, then hit player settings, and select the plugin player settings page. However, using a player settings link from plugins settings page in Default skin means you are navigating to a player settings page, and then selecting a player. Eg. in Fishbone skin, go to SqueezeCenter Settings > Plugins > Music Information Screen, and it displays the MIS player settings. But just above the MIS player settings, it still shows this as SqueezeCenter Settings, as that is where you have come from. The player is selected on the other side of the screen, so it is a bit confusing. >And the user often doesn't care at all whether a feature is added by a plugin >or not. He wants a (almost) single point of configuration. That's the >advanced or player settings page. >Otherwise he would have to go look at the plugins - ooops, not there, let's >try the advanced settings... > I think the word "Advanced" doesn't help - it's really server settings (or other settings that are not player settings and not standard SqueezeCenter settings), but you don't want to use the word "Server". The non-plugin pages (eg. logging, security, network) are advanced settings, but the plugins server settings pages are not necessarily "Advanced". Why would a user think of looking in Advanced settings page for MIS, and not Plugins, Basic, Players or Interface tab? They would know that it was a plugin, as they would have downloaded and installed it as a plugin, so that tab would be fairly high on the list, but probably not Advanced? Especially people coming from 6.5, where there never used to be an advanced tab. But again, I do see the reasoning, as some plugins are built-in and enabled by default, and users need not know the functionality is supplied as built-in plugins. Phil _______________________________________________ plugins mailing list [email protected] http://lists.slimdevices.com/lists/listinfo/plugins
