kolding;268471 Wrote: > Ok, > Since the last version had issues, like it didn't really work, I've > updated AutoDisplay. Now it should actually undim the display when the > appropriate time arrives. I've also cleaned up the scheduling mechanism > a bit. > > Due to packaging problems that have been mentioned in this thread, I > repackaged it by hand to include only what's needed, and not to include > a par file. The result of this is that you'll want to totally remove > your current Plugins/AutoDisplay directory and unzip the new version, > otherwise the old par file will get read, and you'll get some sort of > an unpredictable mess. > > Anyhow, please give it a try. This appears to be a lot more solid and > less of a hack. If the previous was hack/alpha quality, this is > probably all the way up to beta... > http://www.koldware.com/SlimStuff/AutoDisplay.zip > > Please, if you give this a shot and encounter any bugs, let me know. > Thanks... > > Eric
Hi Eric. I just upgraded to SlimCenter and was please to find someone had ported AutoDisplay. It was a bit my baby since I rewrote the algorithim that didn't work correctly and fixed a few bugs. The port seems to work fine but I'm curious about a few things. One quesestion is what did you mean about 'issues' and 'hack'? I've used it forever on two SB3's and one SB2 with SS 6.5.x and earlier (since 0.4a I suppose) and not had a problem; rock solid. What was happening? I know the very earliest versions had some time checking that was just not good. The other is about your code mods. Now I'm not really a perl or plugin guy so I'm syntactically challenged and a little fuzzy on all the variables so bear with me. First I see in the main "checkOnOff" where you did some factoring of $power which is ok and moved $flag which looks fine as long as it can never be undefined as was checked just before where it used to be. Assuming it's OK you might want to move the comment "#If autodisplay has been set to "ON" then continue..." to where you moved $flag. Also if you are cleaning this up then perhaps the rest of the defines could be moved or removed. Second I notice the checking (where "checkOnOff" is called) appears to be in a few more places and is called a lot more frequently. The first version only checked every 60 seconds to keep the load down. This might still be desirable. It is this, previously simple, "setTimer" routine that I don't understand now. It has morphed into something more complicated that in turn calls two other complicated funtions: "now" and "nextTime". I don't quite have the mental energy to wade though them at 2AM and figure them out. Perhaps when you have a minute you could explain what they do. My gut feeling is that they may be a lot more than required for a simple check every minute and they may be a higher load than really needed (particularly with multiple boxes). PS. Thanks again for the port! -- Daryle Tilroe ------------------------------------------------------------------------ Daryle Tilroe's Profile: http://forums.slimdevices.com/member.php?userid=434 View this thread: http://forums.slimdevices.com/showthread.php?t=43104 _______________________________________________ plugins mailing list [email protected] http://lists.slimdevices.com/lists/listinfo/plugins
