Philip Meyer;343792 Wrote: > I'm getting hundreds of the following in my log (about 20 a second): > > [19:46:07.5389] Slim::Player::Protocols::HTTP::new (36) Warning: No > song passed! > It's a change in 7.3, probably due to the synchronization changes, I need do do the same change as the standard MusicIP plugin has done in 7.3 to remove the warnings. Thanks for reporting.
There is an if-statement in 7.3 that prints this warning and then continue as normal, so if you see the ratings in MusicIP I think it works correctly. However, I'm guessing it can affect synchronization quality if you play music with synchronized players during the export operation. Philip Meyer;343827 Wrote: > > I updated the code for addToHistory and tried to restore the stats > again. I only get logging for saveTrack, no warnings from > addToHistory. I can see <historyEntry> nodes in my xml file (within > the same root node as the <track> nodes). > > I have the history setting ticked, and the code change is the same. I > would expect to see some paths that fail to find alternative paths like > saveTrack warning log lines: > > [21:18:21.8444] Plugins::TrackStat::Storage::saveTrack (926) No > matching alternative path found for M:\Music\Phil's > Music\Rips\Coldplay\X&Y\08 - A Message.flac. > I checked the track_history table: SELECT * FROM track_history t where > url like '%Rips%' > > I have over 700 rows that contain urls with "Rips" in them. I've got > rid of this folder from my path (split it into one folder per genre > instead), so there shouldn't be any history row urls with "Rips" in > it. > The $ignoreTrackInSlimserver input variable seems to be set when addToHistory is called, but it isn't set when saveTrack is called. I'm not sure exactly why they differ, spontaneously it feels like they should work the same. Anyway, since you probably put your code in the if-statement that only is entered if $ignoreTrackInSlimserver isn't set, that should be the reason why you have "Rips" track in history and now alternative path's has been searched. I think you will get the correct behavior if you add your code just before the "if($ignoreTrackInSlimserver)" instead of inside that if-statement. This should be the case for both saveTrack and addToHistory. I need to look at this a bit into more detail, but I also think the call to saveTrack in Backup/File.pm should be changed so it sends 1 in the $ignoreTrackInSlimserver parameter. A restore should really restore the data independent if the track exists in SqueezeCenter or not. Philip Meyer;343827 Wrote: > I also looked for track_history rows with url containing "Progressive", > and get 842 rows, so I have new urls in the table too. Most of the > "Rips" track_history row id's are a higher number than the > "Progressive" id's, so the old "Rips" rows have been created after the > corrected ones. > When TrackStat performs a refresh operation, which happens at restarts and after rescans, it will create a history rows for each track that doesn't have a history row. So I bet the situation is as follows: 1. The restore operation restored track_statistics with the new alternative paths 2. The restore operation restored track_history with the old paths 3. The refresh operation created new track_history entries based on the information in track_statistics. The result of this is that your track_history contents isn't correct, it contains correct information with the old paths, but for the correct paths you will just have the last history entry for each track. Philip Meyer;343827 Wrote: > > I see there is also a subroutine called "saveRating" - I haven't > modified this. It appears that I have retrieved last played, rating > and playcount stats from my stats file just by modifying "saveTrack". > saveRating isn't used during restore, it's only used when the use changes a rating, so you shouldn't have to modify that. Modifying saveTrack and addToHistory should be enough to make sure the information is restored correctly with the new paths. -- erland Erland Isaksson 'My homepage' (http://erland.isaksson.info) 'My download page' (http://erland.isaksson.info/download) (Developer of 'TrackStat, SQLPlayList, DynamicPlayList, Custom Browse, Custom Scan, Custom Skip, Multi Library and Database Query plugins' (http://wiki.erland.isaksson.info/index.php/Category:SlimServer)) ------------------------------------------------------------------------ erland's Profile: http://forums.slimdevices.com/member.php?userid=3124 View this thread: http://forums.slimdevices.com/showthread.php?t=52937 _______________________________________________ plugins mailing list [email protected] http://lists.slimdevices.com/lists/listinfo/plugins
