[ http://issues.apache.org/jira/browse/PLUTO-219?page=all ]

Elliot Metsger updated PLUTO-219:
---------------------------------

    Attachment: PLUTO-219-01.patch

Again more for keeping progress to date.  The patch applies cleanly against 
1.0.1-release and works as well.  I'd like to put in a couple more tests.

This patch adds:

descriptors/src/java/org/apache/pluto/descriptors/servlet/DistributableDD.java
  A class for modeling the <distributable> element of the web.xml

descriptors/src/java/org/apache/pluto/descriptors/servlet/DistributableDDCastorFieldHandler.java
  A custom Castor field handler which intercepts the getValue() call to the 
"Distributable" field.
  It returns null if the underlying DistributableDD field is set to false so 
that the <distributable>
  element won't be printed out when it isn't supposed to be.

descriptors/src/java/org/apache/pluto/descriptors/servlet/DistributableCastorFieldHandler.java
  A custom Castor field handler which intercepts the getValue() call to the 
DistributableDD field.
  It always returns null because the <distributable> element cannot carry 
content.

This patch modifies:

descriptors/src/test/org/apache/pluto/descriptors/servlet/WebAppDDTest.java
  Added a test for the the WebAppDD getDistributable() method

descriptors/src/java/org/apache/pluto/descriptors/servlet/WebAppDD.java
  Changes the type of the distributable field from boolean to DistributableDD 
and updates accessors appropriately.

descriptors/src/conf/org/apache/pluto/descriptors/servlet/castor-web-xml-mapping.xml
  Updates the Distributeable <field>'s type, and adds a custom handler for the 
field.
  Adds a <class> mapping for the DistributableDD type which also includes a 
custom handler. 

> <distributable> element in web.xml files produced by the descriptor/depolyer 
> sub-projects is not valid with respect to the Servlet 2.4 xsd
> ------------------------------------------------------------------------------------------------------------------------------------------
>
>          Key: PLUTO-219
>          URL: http://issues.apache.org/jira/browse/PLUTO-219
>      Project: Pluto
>         Type: Bug
>     Versions: 1.0.1
>  Environment: Apache Tomcat 5.5.15
> Servlet 2.4 webapp
>     Reporter: Elliot Metsger
>  Attachments: PLUTO-219-01.patch
>
> Perhaps against best practices I have a portlet that puts objects into 
> session attributes that don't implement Serializable.  Normally I prevent 
> warnings from Tomcat by configuring a session manager (a <Manager> element 
> inside a <Context> container) with an empty path name.  See 
> http://tomcat.apache.org/tomcat-5.5-doc/config/manager.html#Standard%20Implementation
>  (look for the pathname attribute).
> However Tomcat (at least v 5.5.15 does) seems to ignore my <Manager 
> pathname=""/> directive when the portlet's web.xml has a "<distributable>" 
> element present.  Tomcat then fires off errors about placing non-serializable 
> objects in the portlet session.
> I think the Pluto descriptors/deployer needs to put the <distributable> 
> element into a web.xml only when its required.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira

Reply via email to