Hi Craig!

Thanks for the update - back at you :-)

> Refactoring the Ant target for doing tar and bzip2 files, so hopefully that 
> will clean up the bzip and permission issues. 

bzip is cleaned up (bzip2 -d works properly) but permissions were a little 
borked - the *.sh files were being placed directly under <PLUTO_HOME> (instead 
of <PLUTO_HOME>/bin) with +x set.  Here's a diff for the fix:
Index: dist-build.xml
===================================================================
--- dist-build.xml      (revision 396026)
+++ dist-build.xml      (working copy)
@@ -116,13 +116,13 @@
                <bzip2 src="${dist.basedir}/${pluto.name}-bin.tar" 
                        destfile="${dist.basedir}/${pluto.name}-bin.tar.bz2"/>
                                
-               <antcall target="clean"/>       
+               <antcall target="clean"/>
        </target>
        
        <target name="tar-nocompress" description="Creates tar binary 
distributions">
                <tar destfile="${dist.basedir}/${pluto.name}-bin.tar">
-                       <tarfileset prefix="${pluto.name}" 
dir="${dist.dir}/bin" mode="755" username="pluto" group="pluto">
-                       <include name="*.sh"/>
+                       <tarfileset prefix="${pluto.name}" dir="${dist.dir}" 
mode="755" username="pluto" group="pluto">
+                       <include name="bin/*.sh"/>
                        </tarfileset>
                        <tarfileset prefix="${pluto.name}" dir="${dist.dir}" 
username="pluto" group="pluto">
                                <include name="**/*"/>

By the way, I attempted to build the binary dist from the SVN trunk to check 
the above fix.  The fix works: the *.sh files are where they're supposed to be 
under <PLUTO_HOME>/bin/*.sh with +x.  But when I start Tomcat, Pluto doesn't 
start - war files are missing from <PLUTO_HOME>/PlutoDomain/.  Perhaps you have 
changes not yet checked in?  No biggie atm -  looks like there's a fatfinger in 
o.a.p.maven.ReinstallMojo and UninstallMojo when Carsten added the license - 
that may be it.

> Modification of the Tomcat5FileSystemInstaller class to make all the file 
> separators in the Tomcat context DDs docBase attribute forward slashes.

Fixed!  No problems here.

> That LocalStrings error shows up in my console too, but it appears to not 
> be a problem. It's something that we can let slip for a beta release.

Agreed, I can put in a Jira if you want.

As far as executing the test portlets go, test #10 - the Session Timeout Test, 
of portlet 2 fails.  No matter what order I execute the tests in, and no matter 
if I do the tests in portlet 2 before portlet 1 or vice versa.

That's all from just the .bz2 binary dist - I'll plan on doing more testing 
with the .tar.gz binary dists then move onto the source dists.

Reply via email to