David H. DeWolf wrote:


Elliot Metsger wrote:
David,

I've come across a minor thing. Question: do you want to commit fixes on the existing 1.1.0 tag or on the trunk?

I don't think we should ever update a tag. Let's patch the trunk and if we determine we need a new build, we can retag.\

Cool - I agree.


I wonder if in the future it would be better to build release candidate builds straight from trunk. As problems are found with the release candidates, we can apply them to trunk, and not to a tag. Then after we are happy with the fixes and we've determined we don't need another release candidate, we can use the maven plugin to actually create the tag.

SVN tags are actually VERY cheap. I think it'd be a lot easier to simple remove the tag and start over.

Yes.

My concern about starting over was that the maven plugin couldn't roll back from 1.1.1-SNAPSHOT to 1.1.0-SNAPSHOT. But looking closer I realize that only the base pom.xml is affected so no big deal -

I'll patch the trunk -E


What do you think?

Here's the fix (problem is pluto-portal is including servlet-api.jar in the webapp):

Index: pluto-portal/pom.xml
===================================================================
--- pluto-portal/pom.xml        (revision 505110)
+++ pluto-portal/pom.xml        (working copy)
@@ -21,7 +21,7 @@
             <exclusions>
                 <exclusion>
                     <groupId>javax.servlet</groupId>
-                    <artifactId>jsp-api</artifactId>
+                    <artifactId>servlet-api</artifactId>
                 </exclusion>
                 <exclusion>
                     <groupId>xml-apis</groupId>
@@ -42,7 +42,7 @@
             <exclusions>
                 <exclusion>
                     <groupId>javax.servlet</groupId>
-                    <artifactId>jsp-api</artifactId>
+                    <artifactId>servlet-api</artifactId>
                 </exclusion>
                 <exclusion>
                     <groupId>xml-apis</groupId>
@@ -101,4 +101,4 @@

     </build>

-</project>
\ No newline at end of file
+</project>


Good catch. I think we actually want to exclude both jsp-api and servlet-api. We don't want to change the jsp-api exclude, we want to add the servlet one - right?

Patch the trunk. I can recut the tag -- that's the whole purpose for the "test build" before the release.

David

David H. DeWolf wrote:
The test build of Pluto 1.1.0 is available.

No determination as to the quality ('alpha,' 'beta,' or 'GA') of Pluto 1.1.0 has been made, and at this time it is simply a "test build". We welcome any comments you may have, and will take all feedback into account if a quality vote is called for this build.

Release notes:
 * http://svn.apache.org/repos/asf/portals/pluto/tags/pluto-1.1.0/README

Distribution:
 * http://people.apache.org/builds/portals-pluto/

Maven 2 staging repository:
  * http://people.apache.org/builds/portals-pluto/m2-staging-repository/

We appreciate the time and effort everyone has put toward testing, contributing code and documentation, posting to the mailing lists, and logging issues.

I will call a vote on this test build to determine it's status after allowing comments for a couple of days.

Reply via email to