[ 
https://issues.apache.org/jira/browse/PLUTO-442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12550938
 ] 

Craig Doremus commented on PLUTO-442:
-------------------------------------

Applied pluto-portal.patch and  pluto-testsuite.afewfiltertests.patch locally 
to 1.1-286-trunk-merge branch. This fixes all issues reported here 
https://issues.apache.org/jira/browse/PLUTO-442#action_12550045 except the last 
one, but the 286 Test Companion portlet on the JSR 286 Tests page errors out 
with this stack trace:

javax.portlet.PortletException: javax.servlet.ServletException: 
javax.servlet.jsp.JspException: An error occurred while evaluating custom 
action attribute "test" with value "${empty renderRequest.publicParameterMap}": 
An error occurred while getting property "publicParameterMap" from an instance 
of class org.apache.pluto.internal.impl.RenderRequestImpl 
(java.lang.UnsupportedOperationException: This method needs to be implemented.)
        at 
org.apache.pluto.internal.impl.PortletRequestDispatcherImpl.internalInclude(PortletRequestDispatcherImpl.java:185)
        at 
org.apache.pluto.internal.impl.PortletRequestDispatcherImpl.include(PortletRequestDispatcherImpl.java:127)
        at 
org.apache.pluto.testsuite.test.jsr286.TestCompanionPortlet.doView(TestCompanionPortlet.java:34)
        at javax.portlet.GenericPortlet.doDispatch(GenericPortlet.java:340)
        at javax.portlet.GenericPortlet.render(GenericPortlet.java:246)
        at 
org.apache.pluto.core.PortletServlet.dispatch(PortletServlet.java:234)
        at org.apache.pluto.core.PortletServlet.doGet(PortletServlet.java:158)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
        at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
        at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
        at 
org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:691)
        at 
org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:594)
        at 
org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:505)
        at 
org.apache.pluto.core.DefaultPortletInvokerService.invoke(DefaultPortletInvokerService.java:205)
        at 
org.apache.pluto.core.DefaultPortletInvokerService.render(DefaultPortletInvokerService.java:107)
        at 
org.apache.pluto.core.PortletContainerImpl.doRender(PortletContainerImpl.java:198)
        at 
org.apache.pluto.driver.tags.PortletTag.doStartTag(PortletTag.java:152)
        at 
org.apache.jsp.WEB_002dINF.themes.portlet_002dskin_jsp._jspx_meth_pluto_005fportlet_005f0(portlet_002dskin_jsp.java:101)
        at 
org.apache.jsp.WEB_002dINF.themes.portlet_002dskin_jsp._jspService(portlet_002dskin_jsp.java:76)
        at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
        at 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:328)
        at 
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315)
        at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
        at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
        at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
        at 
org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:691)
        at 
org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:594)
        at 
org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:505)
        at 
org.apache.jasper.runtime.JspRuntimeLibrary.include(JspRuntimeLibrary.java:965)
        at 
org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspx_meth_c_005fforEach_005f2(pluto_002ddefault_002dtheme_jsp.java:542)
        at 
org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspx_meth_c_005fotherwise_005f0(pluto_002ddefault_002dtheme_jsp.java:430)
        at 
org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspx_meth_c_005fchoose_005f0(pluto_002ddefault_002dtheme_jsp.java:290)
        at 
org.apache.jsp.WEB_002dINF.themes.pluto_002ddefault_002dtheme_jsp._jspService(pluto_002ddefault_002dtheme_jsp.java:150)
        at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
        at 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:328)
        at 
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315)
        at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
        at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
        at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
        at 
org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:691)
        at 
org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:469)
        at 
org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:403)
        at 
org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:301)
        at 
org.apache.pluto.driver.PortalDriverServlet.doGet(PortalDriverServlet.java:184)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:690)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
        at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
        at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
        at 
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:210)
        at 
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:174)
        at 
org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:525)
        at 
org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
        at 
org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:117)
        at 
org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:108)
        at 
org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:151)
        at 
org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:870)
        at 
org.apache.coyote.http11.Http11BaseProtocol$Http11ConnectionHandler.processConnection(Http11BaseProtocol.java:665)
        at 
org.apache.tomcat.util.net.PoolTcpEndpoint.processSocket(PoolTcpEndpoint.java:528)
        at 
org.apache.tomcat.util.net.LeaderFollowerWorkerThread.runIt(LeaderFollowerWorkerThread.java:81)
        at 
org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run(ThreadPool.java:685)
        at java.lang.Thread.run(Thread.java:595)
Caused by: javax.servlet.ServletException: javax.servlet.jsp.JspException: An 
error occurred while evaluating custom action attribute "test" with value 
"${empty renderRequest.publicParameterMap}": An error occurred while getting 
property "publicParameterMap" from an instance of class 
org.apache.pluto.internal.impl.RenderRequestImpl 
(java.lang.UnsupportedOperationException: This method needs to be implemented.)
        at 
org.apache.jasper.runtime.PageContextImpl.doHandlePageException(PageContextImpl.java:846)
        at 
org.apache.jasper.runtime.PageContextImpl.handlePageException(PageContextImpl.java:779)
        at 
org.apache.jsp.jsp.TestCompanionPortlet_jsp._jspService(TestCompanionPortlet_jsp.java:119)
        at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:98)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
        at 
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:328)
        at 
org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:315)
        at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:265)
        at javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
        at 
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:269)
        at 
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:188)
        at 
org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:691)
        at 
org.apache.catalina.core.ApplicationDispatcher.doInclude(ApplicationDispatcher.java:594)
        at 
org.apache.catalina.core.ApplicationDispatcher.include(ApplicationDispatcher.java:505)
        at 
org.apache.pluto.internal.impl.PortletRequestDispatcherImpl.internalInclude(PortletRequestDispatcherImpl.java:178)
        ... 65 more

> Create a Testsuite for JSR-286 features
> ---------------------------------------
>
>                 Key: PLUTO-442
>                 URL: https://issues.apache.org/jira/browse/PLUTO-442
>             Project: Pluto
>          Issue Type: Improvement
>          Components: portlets-testsuite
>    Affects Versions: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
>            Reporter: Craig Doremus
>             Fix For: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
>
>         Attachments: pluto-portal.patch, 
> pluto-testsuite.afewfiltertests.patch, testsuite-annotations.diff, 
> testsuite-with-phase-annotations.patch
>
>
> We need to add JSR-286 (Portlet 2.0) tests to the testsuite. It might be best 
> to create separate portlets for these tests since JSR-286 adds features that 
> facilitate interportlet communication (eventing and public render parameters).
> This issue is a parent issue with specific tasks linked below it including 
> PLUTO-366, PLUTO-367 and PLUTO-368 .

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to