[
https://issues.apache.org/jira/browse/PLUTO-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12551069
]
Craig Doremus commented on PLUTO-444:
-------------------------------------
I applied the latest patch (filters.271107.patch) to the 1.1-286-trunk-merge
branch. When the portal is built, the content of all portlets do not get
rendered and have a 'null' portlet title. This occurs because the calls in
PortletServlet.dispatch() that are comment out with the "Should be called in
the filtermanager" comment above them are not called in FilterManagerImpl or
within its call stack. If I restore the commented out calls, the portlets are
rendered properly, but most of the the testsuite filter tests in PLUTO-442
(pluto-testsuite.afewfiltertests.patch) do not work correctly. I'm not sure if
this has to do with the patch in this issue or the one in PLUTO-442.
> Filter chain is not implemented the right way
> ---------------------------------------------
>
> Key: PLUTO-444
> URL: https://issues.apache.org/jira/browse/PLUTO-444
> Project: Pluto
> Issue Type: Sub-task
> Components: portal driver
> Affects Versions: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
> Reporter: Christian Raschka
> Priority: Critical
> Fix For: 1.1-286-COMPATIBILITY, 1.1-286-trunk-merge
>
> Attachments: filter.231107.patch, filters.271107.patch
>
>
> In my opinion portlet filter should work the same way like servlet filters do:
> An example: If you have a filter chain with filters F1 and F2, then the chain
> is: F1 -> F2 -> target -> F2 -> F1.
> An exception is, if a Filter does not call filterChain.doFilter. Then no
> other filter _or_ the target is invoked and the filter itself is responsible
> for the response.
> (e.g. see http://java.sun.com/products/servlet/Filters.html)
> In the current implementation the target is invoked, no matter if a filter
> blocks the chain or not.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
