[ 
https://issues.apache.org/jira/browse/PLUTO-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Eric Dalquist resolved PLUTO-486.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2.0
                   2.0-refactoring

Generation of the USER_INFO Map was moved out into the 
DefaultRequestAttributeService so the fix was added there. 

Applied to trunk, 1.1-patches and 2.0-refactoring

> The USER_INFO map is re-created every time the USER_INFO attribute is 
> retrieved using getAttribute() on 
> org.apache.pluto.internal.impl.PortletRequestImpl
> ---------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PLUTO-486
>                 URL: https://issues.apache.org/jira/browse/PLUTO-486
>             Project: Pluto
>          Issue Type: Improvement
>          Components: portlet container
>    Affects Versions: 1.1.5
>         Environment: Tomcat 5.5.26
>            Reporter: Nikita Dubrovsky
>            Assignee: Eric Dalquist
>            Priority: Minor
>             Fix For: 2.0-refactoring, 1.2.0, 1.1.6
>
>         Attachments: P486-1.1.x-Rev656347.diff
>
>
> The method getAttribute() on 
> org.apache.pluto.internal.impl.PortletRequestImpl currently handles the 
> USER_INFO attribute as follows:
>         if (PortletRequest.USER_INFO.equals(name)) {
>             return createUserInfoMap();
>         }
> It would be nice if the USER_INFO data were saved into a request attribute, 
> instead of re-creating the map every time. For example:
>         if (PortletRequest.USER_INFO.equals(name)) {
>             Map userInfoMap = (Map) 
> getHttpServletRequest().getAttribute(name);
>             if (userInfoMap == null) {
>                 userInfoMap = createUserInfoMap();
>                 getHttpServletRequest().setAttribute(name, userInfoMap);
>             }
>             return userInfoMap;
>         }

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to