[
https://issues.apache.org/jira/browse/PLUTO-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680410#action_12680410
]
Ate Douma commented on PLUTO-537:
---------------------------------
From: http://www.nabble.com/Re%3A--VOTE--Cleaning-up-our-packages-p22426226.html
As indicated, I've started the package cleanup (PLUTO-537).
But... while doing this, the more it becomes clear this whole SPI package
naming really isn't that appropriate.
While the SPI packaging indicates "pluggable" interfaces to be
provided/implemented by the portal,
in practice a large part of the Pluto provided SPI implementation classes
really are very core/generic/standard and are unlikely to be (completely)
replaced by an embedding portal.
And then, some other interfaces *are* expected to be provided, extended or
replaced by the embedding portal.
Furthermore, some interfaces are more Object model like, while others clearly
are services like.
I'm now planning to follow the suggestion Carsten already somewhat made in his
initial proposal, and use a much more descriptive packaging structure (based on
the previously targeted packaging) which also better "aligns" with the jar
"container" naming:
container-api:
- move o.a.p.* to o.a.p.container
- move o.a.p.driver.* to o.a.p.container.driver
- move.o.a.p.spi.* to o.a.p.container
- move.o.a.p.om.portlet.* to o.a.p.container.om.portlet
and:
- move all o.a.p.container *services* to o.a.p.container.services
container (impl):
- move o.a.p.impl.* to o.a.p.container.impl
- move o.a.p.driver.impl.* to o.a.p.container.driver.impl
- move o.a.p.om.portlet|portlet10.impl to
o.a.p.container.om.portlet|portlet10.impl
- move o.a.p.spi.impl to o.a.p.container.impl
- move.o.a.p.impl.util to o.a.p.container.util
and:
- move all o.a.p.container.impl Default*Services (or similar like
PortletContextManager) to o.a.p.container.driver.impl
- move all o.a.p.container.impl Request/Response*ContextImpl to
o.a.p.container.driver.impl.DefaultRequest/Response*Context
(these really will be only light weight implementations and primarily for
usage by Pluto Portal Driver)
> Cleaning up Pluto packages
> --------------------------
>
> Key: PLUTO-537
> URL: https://issues.apache.org/jira/browse/PLUTO-537
> Project: Pluto
> Issue Type: Task
> Components: portlet container
> Affects Versions: 2.0.0
> Reporter: Ate Douma
> Assignee: Ate Douma
> Fix For: 2.0.0
>
>
> A cleaning up of the current Pluto packages was proposed initially by Casten
> on the dev list, see:
> http://www.nabble.com/-RT--Cleaning-up-our-packages-p22288945.html
> A follow up proposal was accepted on the dev list, see:
> http://www.nabble.com/Re%3A--RT--Cleaning-up-our-packages-p22414927.html
> defining the following changes which will be done:
> container-api:
> - o.a.p
> leave as is
> - o.a.p.core
> rename to o.a.p.driver
> move NullPortlet as inner class to PortletServlet
> - o.a.p.services
> move PortletAppDescriptorServices to o.a.p.spi
> move ContainerServices to o.a.p
> move PlutoServices to o.a.p.driver (side-by-side PortletServlet)
> - o.a.p.om.portlet
> leave as is
> - o.a.p.internal
> rename Internal* to Container* (I really don't like the "Internal"
> prefix)
> move * to o.a.p
> - o.a.p.spi.optional
> move * to o.a.p.spi
> the distinction between spi and spi.optional (while somewhat useful
> configuration wise) really is too artificial technical wise imo.
> container (impl):
> - o.a.p
> move PortletContainerFactory to o.a.p.driver.impl
> - o.a.p.core
> move the following to new package o.a.p.impl
> ContainerInvocation* (note: I've some ideas to completely get rid of
> these all together)
> PlutoContainerServices
> PortletContainerImpl
> move all the others to either
> - o.a.p.driver.impl (those which really are used only by/for a
> standalone/pure embedded driver)
> - o.a.p.spi.impl (those which are of more generic usage and/or
> embedding in a larger portal)
> drop package o.a.p.core
> - o.a.p.descriptors.portlet, o.a.p.descriptors.portlet10
> rename these to o.a.p.om.portlet.impl and o.a.p.om.portlet10.impl
> - o.a.p.descriptors.services.jaxb
> move PortletAppDescriptorServiceImpl to o.a.p.spi.impl
> - o.a.p.internal.impl
> move * to o.a.p.impl
> - o.a.p.util
> move to o.a.p.impl.util
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
