[
https://issues.apache.org/jira/browse/PLUTO-579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12759053#action_12759053
]
Ate Douma commented on PLUTO-579:
---------------------------------
Hi David,
I looked briefly at both the patch and the current Pluto trunk
PortalURLParserImpl.
While a lot of the code still looks the same, there is one major difference: in
trunk parameters are first passed through URLEncoder/URLDecoder before/after
the custom encoding/decoding is done like in Pluto 1.1.x.
As URLEncoder already takes care of ';' characters I think this issue no longer
applies to trunk anymore.
And it seems to me the custom encoding/decoding on trunk could actually now
ignore some of the characters currently defined in the ENCODINGS array.
If using URLEncoder/URLDecoder is as efficient as the new custom
encoding/decoding in Pluto 1.1.x branch I don't know.
So, for performance reasons, it might be interested to review if we should
replace the trunk code with this one, but functionally I don't think its needed
anymore.
> Some render parameters are lost if they contains semicolon
> ----------------------------------------------------------
>
> Key: PLUTO-579
> URL: https://issues.apache.org/jira/browse/PLUTO-579
> Project: Pluto
> Issue Type: Bug
> Components: portal driver
> Affects Versions: 1.1.7
> Reporter: Ivan
> Assignee: David Jencks
> Fix For: 2.0.1, 1.1.8
>
> Attachments: PLUTO-579-0921.patch, PLUTO-579.patch
>
>
> If one render parameter contains semicolon, those parameters after it in the
> url are lost
> Like the URL below
> __pm0x3system-database0x2DBWizard!1134683811|0_view/__rp0x3system-database0x2DBWizard!1134683811|0_rarPath/org0x2tranql0x3tranql-connector-ra0x30x3rar/__rp0x3system-database0x2DBWizard!1134683811|0_driverClass/com0x2microsoft0x2sqlserver0x2jdbc0x2SQLServerDriver/__rp0x3system-database0x2DBWizard!1134683811|0_mode/params/__rp0x3system-database0x2DBWizard!1134683811|0_dbtype/SQL0x8Server0x82005/__rp0x3system-database0x2DBWizard!1134683811|0_adapterDisplayName/TranQL0x8Generic0x8JDBC0x8Resource0x8Adapter/__rp0x3system-database0x2DBWizard!1134683811|0_urlPrototype/jdbc:sqlserver:0x30x3%7BHost%7D:%7BPort%7D;DatabaseName=%7BDatabase%7D/__rp0x3system-database0x2DBWizard!1134683811|0_transactionType/LOCAL/__rp0x3system-database0x2DBWizard!1134683811|0_name/ddddd
> The parameter urlPrototype contains semicolon, while I calling
> renderRequest.getParameter("name"), it will return null.
> After some investigations, I found in the class PortalURLParserImpl, line 115
> String pathInfo = request.getPathInfo(); <--- the pathInfo got from
> the request is truncated by the semicolon.
> if (pathInfo == null) {
> Maybe, we need to add the ; to the ENCODINGS arrays ?
> Thanks !
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
