HttpServletPortletRequestWrapper.getAttribute delegates to wrapped 
ServletRequest
---------------------------------------------------------------------------------

                 Key: PLUTO-600
                 URL: https://issues.apache.org/jira/browse/PLUTO-600
             Project: Pluto
          Issue Type: Bug
          Components: portlet container
            Reporter: Eric Dalquist
            Assignee: Eric Dalquist
             Fix For: 2.1.0


The HttpServletPortletRequestWrapper.getAttribute(String) method is doing fall 
back to retrieve the attribute from the underlying ServletRequest
{code}
// First try to retrieve the attribute from the (possibly 
buffered/cached/previously set) portletRequest
Object value = portletRequest.getAttribute(name);
// if null, fall back to retrieve the attribute from the web container itself
return value != null ? value : getRequest().getAttribute(name);
{code}

The problem with this is it nullifies the portal's ability to influence the 
request attributes that can be seen by a portlet and any servlets it dispatches 
to via the PortletRequestContext. Since the default PortletRequestContextImpl 
in Pluto already has the ServletRequest.getAttribute(String) fallback code I 
believe it can be removed from HttpServletPortletRequestWrapper.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to