[ 
https://issues.apache.org/jira/browse/PLUTO-668?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Neil Griffin updated PLUTO-668:
-------------------------------
    Description: 
Both V3URLTests_BaseURL_append and V3URLTests_BaseURL_append2 call 
{{baseURL.setParameter("tr1", ">&'\"")}} followed by 
{{baseURL.append(Appendable)}} in order to verify that the following characters 
are not present in the {{Appendable}} object:
- >
- &
- '
- "

The check for the absence of the ampersand character is done like this:
{code:java|title=URLTests_BaseURL.java}
if (!resultingString.contains("&") {
    ...
}
{code}
However, this check assumes that the portlet container will not use the 
ampersand character in any way. Liferay Portal typically separates URL 
parameters with an ampersand, which causes the aforementioned tests to fail in 
Liferay Portal. The reason why this works on Apache Pluto is because it never 
uses an ampersand to separate URL parameters.

The proposed solution would be to simply eliminate the check for the presence 
of an ampersand character.

  was:
Both V3URLTests_BaseURL_append and V3URLTests_BaseURL_append2 call 
{{baseURL.setParameter("tr1", ">&'\"")}} followed by 
{{baseURL.append(Appendable)}} in order to verify that the following characters 
are not present in the {{Appendable}} object:
- >
- &
- '
- "
The check for the absence of the ampersand character is done like this:
{code:java|title=URLTests_BaseURL.java}
if (!resultingString.contains("&") {
    ...
}
{code}
However, this check assumes that the portlet container will not use the 
ampersand character in any way. Liferay Portal typically separates URL 
parameters with an ampersand, which causes the aforementioned tests to fail in 
Liferay Portal. The reason why this works on Apache Pluto is because it never 
uses an ampersand to separate URL parameters.

The proposed solution would be to simply eliminate the check for the presence 
of an ampersand character.


> TCK: Contesting V3URLTests_BaseURL_append and V3URLTests_BaseURL_append2
> ------------------------------------------------------------------------
>
>                 Key: PLUTO-668
>                 URL: https://issues.apache.org/jira/browse/PLUTO-668
>             Project: Pluto
>          Issue Type: Bug
>          Components: tck
>    Affects Versions: 3.0.0
>            Reporter: Neil Griffin
>            Assignee: Neil Griffin
>             Fix For: 3.0.1
>
>
> Both V3URLTests_BaseURL_append and V3URLTests_BaseURL_append2 call 
> {{baseURL.setParameter("tr1", ">&'\"")}} followed by 
> {{baseURL.append(Appendable)}} in order to verify that the following 
> characters are not present in the {{Appendable}} object:
> - >
> - &
> - '
> - "
> The check for the absence of the ampersand character is done like this:
> {code:java|title=URLTests_BaseURL.java}
> if (!resultingString.contains("&") {
>     ...
> }
> {code}
> However, this check assumes that the portlet container will not use the 
> ampersand character in any way. Liferay Portal typically separates URL 
> parameters with an ampersand, which causes the aforementioned tests to fail 
> in Liferay Portal. The reason why this works on Apache Pluto is because it 
> never uses an ampersand to separate URL parameters.
> The proposed solution would be to simply eliminate the check for the presence 
> of an ampersand character.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to