Neil Griffin created PLUTO-682:
----------------------------------

             Summary: TCK: Contesting tests that do not expect public render 
parameters to be present in the return value of PortletRequest.getParameterMap()
                 Key: PLUTO-682
                 URL: https://issues.apache.org/jira/browse/PLUTO-682
             Project: Pluto
          Issue Type: Bug
          Components: tck
    Affects Versions: 3.0.0
            Reporter: Neil Griffin
            Assignee: Neil Griffin
             Fix For: 3.0.1


The following tests call {{PortletRequest.getParameterMap()}} and do not expect 
public render parameters to be present:
 * V2URLTests_BaseURL_ApiRenderActurl_setParameterA1
 * V2URLTests_BaseURL_ApiRenderActurl_setParameters6
 * V2URLTests_BaseURL_ApiRenderActurl_setParameters8
 * V2URLTests_BaseURL_ApiRenderActurl_setParameters4
 * V2URLTests_BaseURL_ApiRenderRenurl_setParameters3
 * V2URLTests_BaseURL_ApiRenderResurl_setParameters5

These tests pass in Apache Pluto, but they fail in Liferay with errors like the 
following:
{quote}Method setParameters(java.util.Map): Sets the parameter map to the 
specified value. In Request but not in expected: `tckPRP1`
{quote}
In JSR 362 issue "[PORTLETSPEC3-5] Errata: Clarification about Private Render 
Parameters" the decision was made to clarify the [Javadoc for 
PortletRequest.getParameterMap()|https://portals.apache.org/pluto/portlet-3.0-apidocs/javax/portlet/PortletRequest.html#getParameterMap()]
 from "Returns a Map of the parameters of this request" to "Returns a Map of 
*all public and private parameters* of this request."

One of the justifications for this change was that "Both Apache Pluto container 
and Jetspeed-2 Portal have been implemented" in this way. However, since Apache 
Pluto passes the aforementioned tests, that may have been an incorrect 
statement.

The proposed fix for this problem would be to:

1) Fix the test to expect Public Render Parameters to be present.

2) Fix Apache Pluto so that it includes the Public Render Parameters.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to