Send plymouth mailing list submissions to plymouth@lists.freedesktop.org
To subscribe or unsubscribe via the World Wide Web, visit http://lists.freedesktop.org/mailman/listinfo/plymouth or, via email, send a message with subject or body 'help' to plymouth-requ...@lists.freedesktop.org You can reach the person managing the list at plymouth-ow...@lists.freedesktop.org When replying, please edit your Subject line so it is more specific than "Re: Contents of plymouth digest..." Today's Topics: 1. Re: [PATCH] [details] Handle NULL boot_buffer (Ray Strode) 2. Re: [PATCH 1/2] [main] Fix parsing of plymouth:debug=file: (Ray Strode) 3. Re: [PATCH 2/2] [main] Handle plymouth:splash or plymouth:debug as last argument (Ray Strode) ---------------------------------------------------------------------- Message: 1 Date: Mon, 3 May 2010 10:03:29 -0400 From: Ray Strode <halfl...@gmail.com> Subject: Re: [PATCH] [details] Handle NULL boot_buffer To: Colin Watson <cjwat...@ubuntu.com> Cc: plymouth@lists.freedesktop.org Message-ID: <g2h45abe7d81005030703x993cde62pa164dcd3c8d14...@mail.gmail.com> Content-Type: text/plain; charset=UTF-8 Hi, On Wed, Apr 28, 2010 at 8:31 AM, Colin Watson <cjwat...@ubuntu.com> wrote: > boot_buffer may be NULL if plymouthd failed to attach to the console > session (e.g. if booting without an initramfs so /dev/pts isn't mounted > yet). ?Handle this gracefully rather than segfaulting. Thanks, committed. ------------------------------ Message: 2 Date: Mon, 3 May 2010 10:04:30 -0400 From: Ray Strode <halfl...@gmail.com> Subject: Re: [PATCH 1/2] [main] Fix parsing of plymouth:debug=file: To: Colin Watson <cjwat...@ubuntu.com> Cc: plymouth@lists.freedesktop.org Message-ID: <j2v45abe7d81005030704ue2084e4dx5132406ecec3e...@mail.gmail.com> Content-Type: text/plain; charset=UTF-8 Hi, On Wed, Apr 28, 2010 at 8:27 AM, Colin Watson <cjwat...@ubuntu.com> wrote: > Short-circuit evaluation meant that the path variable was never set if > plymouth:debug=file: was used. ?Switch the ordering around to fix this. Ah, nice find. Committed. --Ray ------------------------------ Message: 3 Date: Mon, 3 May 2010 10:07:57 -0400 From: Ray Strode <halfl...@gmail.com> Subject: Re: [PATCH 2/2] [main] Handle plymouth:splash or plymouth:debug as last argument To: Colin Watson <cjwat...@ubuntu.com> Cc: plymouth@lists.freedesktop.org Message-ID: <y2x45abe7d81005030707sc6dd33efx5f729d2b245b5...@mail.gmail.com> Content-Type: text/plain; charset=UTF-8 Hi, On Wed, Apr 28, 2010 at 8:28 AM, Colin Watson <cjwat...@ubuntu.com> wrote: > If plymouth:splash or plymouth:debug is the last argument in > /proc/cmdline, then it will be terminated with '\n' rather than ' '. > Handle this. This is good, too, pushed. We should probably have a little helper function at some point instead of all the open coded strstr and string + length stuff, but that's a clean up I can do in some distant future point. --Ray ------------------------------ _______________________________________________ plymouth mailing list plymouth@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/plymouth End of plymouth Digest, Vol 19, Issue 1 ***************************************