Send plymouth mailing list submissions to
[email protected]
To subscribe or unsubscribe via the World Wide Web, visit
http://lists.freedesktop.org/mailman/listinfo/plymouth
or, via email, send a message with subject or body 'help' to
[email protected]
You can reach the person managing the list at
[email protected]
When replying, please edit your Subject line so it is more specific
than "Re: Contents of plymouth digest..."
Today's Topics:
1. [PATCH] New ply_boot_client_flush() method to flush outgoing
requests before we exit() (Steve Langasek)
2. Re: [PATCH] New ply_boot_client_flush() method to flush
outgoing requests before we exit() (Ray Strode)
3. [PATCH] drm: fixed bug regarding minimal buffer size
(Kevin Murphy)
4. Re: [PATCH] drm: fixed bug regarding minimal buffer size
(Ray Strode)
----------------------------------------------------------------------
Message: 1
Date: Fri, 11 May 2012 00:38:17 -0700
From: Steve Langasek <[email protected]>
Subject: [PATCH] New ply_boot_client_flush() method to flush outgoing
requests before we exit()
To: [email protected]
Message-ID: <[email protected]>
Content-Type: text/plain; charset="us-ascii"
Hi there,
Below please find a patch to plymouth to add a new function,
ply_boot_client_flush(), which is included in the build of
libply-boot-client on Ubuntu.
This was added in response to this bug:
https://bugs.launchpad.net/ubuntu/+source/mountall/+bug/559761
In some cases, clients may need a way to ensure that messages to plymouthd
have been processed synchronously. This added API call provides this.
--
Steve Langasek Give me a lever long enough and a Free OS
Debian Developer to set it on, and I can move the world.
Ubuntu Developer http://www.debian.org/
[email protected] [email protected]
>From df9b57bf698f62275bcf868f573d451c117e38c3 Mon Sep 17 00:00:00 2001
From: Steve Langasek <[email protected]>
Date: Wed, 9 May 2012 12:57:44 -0700
Subject: [PATCH] New ply_boot_client_flush() method to flush outgoing
requests before we exit()
---
configure.ac | 4 ++--
src/client/ply-boot-client.c | 11 +++++++++++
src/client/ply-boot-client.h | 1 +
3 files changed, 14 insertions(+), 2 deletions(-)
diff --git a/configure.ac b/configure.ac
index 116a4f1..c37c694 100644
--- a/configure.ac
+++ b/configure.ac
@@ -19,7 +19,7 @@ PKG_PROG_PKG_CONFIG
LT_INIT
## increment if the interface has additions, changes, removals.
-LT_CURRENT=2
+LT_CURRENT=3
## increment any time the source changes; set to
## 0 if you increment CURRENT
@@ -28,7 +28,7 @@ LT_REVISION=0
## increment if any interfaces have been added; set to 0
## if any interfaces have been changed or removed. removal has
## precedence over adding, so set to 0 if both happened.
-LT_AGE=0
+LT_AGE=1
AC_SUBST(LT_CURRENT)
AC_SUBST(LT_REVISION)
diff --git a/src/client/ply-boot-client.c b/src/client/ply-boot-client.c
index d76d32d..5d3965d 100644
--- a/src/client/ply-boot-client.c
+++ b/src/client/ply-boot-client.c
@@ -777,6 +777,17 @@ ply_boot_client_tell_daemon_about_error (ply_boot_client_t
*cli
}
void
+ply_boot_client_flush (ply_boot_client_t *client)
+{
+ assert (client != NULL);
+
+ while (ply_list_get_length (client->requests_to_send) > 0)
+ {
+ ply_event_loop_process_pending_events (client->loop);
+ }
+}
+
+void
ply_boot_client_disconnect (ply_boot_client_t *client)
{
assert (client != NULL);
diff --git a/src/client/ply-boot-client.h b/src/client/ply-boot-client.h
index 78fdd21..ca6f37a 100644
--- a/src/client/ply-boot-client.h
+++ b/src/client/ply-boot-client.h
@@ -134,6 +134,7 @@ void ply_boot_client_ask_daemon_has_active_vt
(ply_boot_client_t
ply_boot_client_response_handler_t handler,
ply_boot_client_response_handler_t failed_handler,
void
*user_data);
+void ply_boot_client_flush (ply_boot_client_t *client);
void ply_boot_client_disconnect (ply_boot_client_t *client);
void ply_boot_client_attach_to_event_loop (ply_boot_client_t *client,
ply_event_loop_t *loop);
--
1.7.9.5
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 828 bytes
Desc: Digital signature
URL:
<http://lists.freedesktop.org/archives/plymouth/attachments/20120511/56e6a8fa/attachment-0001.pgp>
------------------------------
Message: 2
Date: Fri, 11 May 2012 08:53:53 -0400
From: Ray Strode <[email protected]>
Subject: Re: [PATCH] New ply_boot_client_flush() method to flush
outgoing requests before we exit()
To: Steve Langasek <[email protected]>
Cc: [email protected]
Message-ID:
<caa_uwzks9ug-ddxoxkspj3rqjymftq2d1xa0dtwa71rnyqx...@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Hi,
On Fri, May 11, 2012 at 3:38 AM, Steve Langasek
<[email protected]> wrote:
> Below please find a patch to plymouth to add a new function,
> ply_boot_client_flush(), which is included in the build of
> libply-boot-client on Ubuntu.
Sure, pushed.
--Ray
------------------------------
Message: 3
Date: Fri, 11 May 2012 10:00:12 -0400
From: Kevin Murphy <[email protected]>
Subject: [PATCH] drm: fixed bug regarding minimal buffer size
To: [email protected]
Message-ID:
<camo0ngzx+hd4vncietokrhvn54ya15lsmohdoj0w1k6f5-r...@mail.gmail.com>
Content-Type: text/plain; charset="iso-8859-1"
And of course that time I missed the Reply All button....
Thanks,
Kevin
---------- Forwarded message ----------
From: *Kevin Murphy*
Date: Thursday, May 10, 2012
Subject: [PATCH] drm: fixed bug regarding minimal buffer size
To: Dave Airlie <[email protected]>
Ah, I thought I pasted it in.... My mistake. Here it is, for real this
time :)
Thanks,
Kevin
On Thu, May 10, 2012 at 3:22 AM, Dave Airlie <[email protected]<javascript:;>>
wrote:
> On Thu, May 10, 2012 at 6:15 AM, Ray Strode <[email protected]<javascript:;>>
wrote:
>> Hey,
>>
>> On Wed, May 9, 2012 at 3:43 PM, Kevin Murphy
>> <[email protected]<javascript:;>>
wrote:
>>> If we ask for a buffer of size 0 when testing for 32bpp framebuffer
>>> support, we trigger a condition in the kernel that will cause the
>>> test to fail, ultimately causing a fallback to the framebuffer
>>> driver.
>>> See
http://lxr.free-electrons.com/source/drivers/gpu/drm/ttm/ttm_bo.c#L1193
>>> for the block of code that gets triggered.
>>
>> Oh, bummer. So ttm drivers report a min_width that's less than they
support?
>>
>>> Compiz ran into a similar
>>> issue at some point and they just forced each minimum dimension to 2
>>> if it detected it was about to ask for a 0, so that's the approach I
>>> took.
>> Sounds fine. I think you forgot to attach the patch though?
>
> Yeah a size > 0 is probably a good plan, I'll fix the kernel to not
> report 0 as well.
>
> Dave.
-------------- next part --------------
An HTML attachment was scrubbed...
URL:
<http://lists.freedesktop.org/archives/plymouth/attachments/20120511/46cd4fe6/attachment-0001.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-drm-fixed-bug-regarding-minimal-buffer-size.patch
Type: application/octet-stream
Size: 1851 bytes
Desc: not available
URL:
<http://lists.freedesktop.org/archives/plymouth/attachments/20120511/46cd4fe6/attachment-0001.obj>
------------------------------
Message: 4
Date: Fri, 11 May 2012 11:56:09 -0400
From: Ray Strode <[email protected]>
Subject: Re: [PATCH] drm: fixed bug regarding minimal buffer size
To: Kevin Murphy <[email protected]>
Cc: [email protected]
Message-ID:
<CAA_UwzKO=GjaZh_o6EqVutXcivb8_i97BMvJssHpRpcQe=l...@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Hi,
> Ah, I thought I pasted it in.... ?My mistake. ?Here it is, for real this
> time :)
I pushed this with minor changes. Basically, I made the minimum width
1x1 instead of 2x2, since 2x2 seems more "magic" and I don't think
it's actually required. If i'm wrong, and things still fail for you,
let me know and I'll do a follow up commit.
--Ray
------------------------------
_______________________________________________
plymouth mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/plymouth
End of plymouth Digest, Vol 40, Issue 6
***************************************
