On Thu, Mar 15, 2007 at 11:31:10PM +0100, Stefan Seyfried wrote:
> IMHO this is an important fix, since you cannot configure anything
> without it.
BTW (i forgot that):
- we could of course basically get rid of all those exports below by
simply doing:
+set -a
> [ -f /usr/lib/pm-utils/defaults ] && . /usr/lib/pm-utils/defaults
+set +a
and then just remove those:
> +export HIBERNATE_RESUME_POST_VIDEO
> +export INHIBIT
> +export PM_LOGFILE
> +export PM_CMDLINE
> +export RESUME_MODULES
> +export SUSPEND_MODULES
> +export TEMPORARY_CPUFREQ_GOVERNOR
I would also (again) question the usefulness of requiring the "x" bit to be
set for the fconfig files, and i would vote for removing the "[ -x $cfg ]"
check below:
> source_configs()
> {
> cfgs="/etc/pm/config.d/*[^~]"
> for cfg in $cfgs ; do
> [ -x $cfg ] || continue
> - while read LINE ; do
> - case "$GLOBAL_CONFIG_VARIABLES " in
> - *" ${LINE%=*} "*) continue ;;
> - *) eval $LINE ;;
> - esac
> - done < $cfg
> + set -a
> + . $cfg
> + set +a
> done
> }
--
Stefan Seyfried
"Any ideas, John?"
"Well, surrounding them's out."
_______________________________________________
Pm-utils mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/pm-utils
