On Jan 27, 2008 8:37 PM, Michael Biebl <[EMAIL PROTECTED]> wrote:
> 2008/1/27, Victor Lowther <[EMAIL PROTECTED]>:
>
> > Use file globbing instead of trying to parse the output of ls, change
> > default governor from "userspace" to "performance" because performance
> > is the compiled-in default for just about everything that uses
> > cpufreq.
>
> + grep -q "$GOVERNOR" "$x/cpufreq/scaling_available_governors" \
> + || gov="performance"
>
> Isn't this a typo, and it should be "$gov" instead of "$GOVERNOR"
Yes, it is a typo. Good catch. Patch attached.
> And to change the default governor during suspend/hibernate, I'd say
> you have to use
>
> --- a/pm/functions
> +++ b/pm/functions
> @@ -15,7 +15,7 @@ HIBERNATE_RESUME_POST_VIDEO=no
> INHIBIT=/var/run/pm-utils.inhibit
> PM_LOGFILE=${PM_LOGFILE:=/var/log/pm-suspend.log}
> SUSPEND_MODULES=""
> -TEMPORARY_CPUFREQ_GOVERNOR="userspace"
> +TEMPORARY_CPUFREQ_GOVERNOR="performance"
>
> # Use c sort order
> export LC_COLLATE=C
>
> || gov="performance" is only a fallback.
Precisely. The code I have is by design -- performance is the
fallback governor. The commit comment is incorrect in this case. :)
> Cheers,
> Michael
>
> --
>
> Why is it that all of the instruments seeking intelligent life in the
> universe are pointed away from Earth?
>
diff -U 0 -rNX /home/victor/pm-utils/trunk/diffignore pm-utils.updates/pm/sleep.d/94cpufreq working/pm/sleep.d/94cpufreq
--- pm-utils.updates/pm/sleep.d/94cpufreq 2008-01-27 14:10:43.000000000 -0600
+++ working/pm/sleep.d/94cpufreq 2008-01-27 20:55:45.000000000 -0600
@@ -13 +13 @@
- grep -q "$GOVERNOR" "$x/cpufreq/scaling_available_governors" \
+ grep -q "$gov" "$x/cpufreq/scaling_available_governors" \
_______________________________________________
Pm-utils mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/pm-utils
