2008/2/17, Victor Lowther <[EMAIL PROTECTED]>: > After examining the source to s2ram and seeing how it does the video > quirk handling, I cannot see why 20video an 99video are seperate hooks. > > This patch aims to rectify that. It does the following things: > * Merge the functionality of 20video and 99video by folding the state > saving that 20video does into 99video. > * Modifies the state saving and restoring code in pm/functions.in to > make savestate also accept the state to save on stdin. This allows > savestate and restorestate to be symmetric and to ensure that they > can handle any type of data without it getting mangled by using a > shell variable as an intermediate stage. > * Make 99video use savestate and restorestate to save and restore vbe > state information across suspend/resume instead of using their own > temporary files. > * Add support for --quirk-none. The latest HAL can run us with it, but > we did not handle it. We do now. > * While I am at it, fix up 94cpufreq to use the new state handling > functionality. This also improves readability. >
Hi Victor, I support the idea of merging 20video into 99video, but your patch does a lot more than that. Could you split them into smaller patches, where each patch addresses the above points separately. Cheers, Michael -- Why is it that all of the instruments seeking intelligent life in the universe are pointed away from Earth? _______________________________________________ Pm-utils mailing list [email protected] http://lists.freedesktop.org/mailman/listinfo/pm-utils
