On Wed, Feb 24, 2010 at 9:41 AM, Till Maas <opensou...@till.name> wrote: > Hi, > > today I realised that a hook in Fedora that was not meant to exist that > long is already there for two years. It restores the harddisk APM > settings on thaw/resume: > > http://cvs.fedoraproject.org/viewvc/rpms/pm-utils/devel/pm-utils-99hd-apm-restore?revision=1.7&view=markup > http://cvs.fedoraproject.org/viewvc/rpms/pm-utils/devel/pm-utils-hd-apm-restore.conf?revision=1.2&view=markup
A couple comments about this feature. 1. One thing I never liked about this is that there's no way to disable it without blacklisting it outright. I don't change my hd apm settings, so I don't need hal and hdparm to figure out what my current settings are, etc. What I want to do is set HD_APM_DEVICES="" in the conf file and have the hook just exit in that case. 2. HD_APM_DEVICES in the conf file is completely ignored. No matter the value, the hook then goes and asks hal for all the devices. 3. The conf file should probably live in /etc/pm/ with the rest of the pm-utils configuration. Finally, I think it needs to be asked why we're doing this in userspace at all. Shouldn't the kernel be restoring the settings for us like it does for every other device type? -- Dan _______________________________________________ Pm-utils mailing list Pm-utils@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/pm-utils
