I've got a bug report about compile failures on amd64 platforms with GCC 4, so I'm going through the compiler warnings and trying to fix some of the more obvious ones.
One of these is in pmacct.c:605, which causes the error in the subject line. The data structure pkt_primitives declares proto to be a u_int8, so when you compare it with 0 or 255 it will always fail; the variable can never have these values. Is it worth just removing this if-block, or are there compilers that will make u_int8 into a larger signed integer and thus this code isn't redundant?
