Hey Jamie, On Mon, Aug 22, 2005 at 03:44:36PM +1000, Jamie Wilkinson wrote:
> Also the fact that this constant is defined in two places (but appears to > only be used in sql_common.h) sets of alarm bells in my mind; and the fact > that it's not really the value of maximum size of a 32 bit unsigned integer > tells me that the name is misleading too. Thank you for the patch. The UINT32TMAX is used in SQL plugins (so, it is set in sql_common.h) and print plugin (so, it is set in print_plugin.h). The value is used as a threshold to avoid overflows in 32b bytes/packets/flows counters. This is because it is slightly lower than the real limit of the counter: as the threshold is hit, the entry in the cache is considered "closed". Cheers, Paolo
