Hi Karl,

Thanks for contributing this patch. It makes sense, doesn't
break anything and hence i've committed it right away into
the CVS with the following description:

* net_aggr.c: support is introduced for descriptions in the file pointed
  by a networks_file configuration directive. Thanks to Karl O. Pinc for
  contributing the patch.

Cheers,
Paolo


On Mon, Mar 09, 2009 at 08:57:01PM -0500, Karl O. Pinc wrote:
> Hi,
>
> Attached is a patch so that the networks file
> can contain comments.  (Apparently it can contain
> comments now, but there's memory allocated as if
> each comment line was a network specification.
> And you occasionally get errors that
> don't matter depending on
> comment content. E.g the comment
> ! We're not using 192.168.0.0/16 on alternate Tuesdays.
> produces an ignorable error.  (IIRC.)
> )
>
> This patch works for me.  I would not swear
> up and down that it does not break things,
> mostly because I'm not super clear on what
> the syntax and semantics of the networks
> file is supposed to be.  I think I know,
> but I don't find the examples/network.lst.example
> file 100% unambiguous.  I'm 99% sure it works,
> but...
>
> Against cvs.  To apply:
>
> cd pmacct
> patch < net_aggr-comment.patch
>
>
> Karl <[email protected]>
> Free Software:  "You don't pay back, you pay forward."
>                  -- Robert A. Heinlein

_______________________________________________
pmacct-discussion mailing list
http://www.pmacct.net/#mailinglists

Reply via email to