Hi Joel, Your proposal makes sense. However, as you know, devil is in these innocent one liners. I'd not go ahead with this change approx one month from upcoming release, 1.5.0rc2. I'd also encourage you to patch your code and confirm you do not run into any issues. I'm adding to my todo list to ping you about this shortly after rc2 is out - that would be great moment to introduce this.
Cheers, Paolo On Sat, Dec 07, 2013 at 11:05:14AM -0800, Joel Krauska wrote: > Would it be possible to adjust the config file parser to accept # as an > alternative to !? > > I find myself using !# as it 'does the right thing' in most syntax > highlighting. > > But !# means something else to scripters. > > util.c: 287 (in int iscomment(char *line)) > if (line[j] == '!' || line[j] == '#' ) return TRUE; > > Clearly I'm down to nitpicky cosmetic issues. :) > > Thanks for all your help! > > --Joel > _______________________________________________ > pmacct-discussion mailing list > http://www.pmacct.net/#mailinglists _______________________________________________ pmacct-discussion mailing list http://www.pmacct.net/#mailinglists
