Hi Ruben,
Thanks for that. Patch accepted and will commit to CVS later today.
Cheers,
Paolo
On Fri, Jan 31, 2014 at 10:23:44AM +0100, Ruben Laban wrote:
> Hi Paolo,
>
> I've been meaning to send you this patch for ages (unless I did and
> forgot about it);
>
> Index: src/signals.c
> ===================================================================
> RCS file: /home/repo-0.14/pmacct/src/signals.c,v
> retrieving revision 1.7
> diff -u -r1.7 signals.c
> --- src/signals.c 6 Jan 2014 17:56:22 -0000 1.7
> +++ src/signals.c 31 Jan 2014 09:18:46 -0000
> @@ -170,7 +170,7 @@
> if (config.acct_type == ACCT_PM) {
> if (config.dev) {
> if (pcap_stats(glob_pcapt, &ps) < 0) Log(LOG_INFO,
> "\npcap_stats: %s\n", pcap_geterr(glob_pcapt));
> - Log(LOG_NOTICE, "\n%s: (%u) %u packets received by filter\n",
> config.dev, now, ps.ps_recv);
> + Log(LOG_NOTICE, "%s: (%u) %u packets received by filter\n",
> config.dev, now, ps.ps_recv);
> Log(LOG_NOTICE, "%s: (%u) %u packets dropped by kernel\n",
> config.dev, now, ps.ps_drop);
> }
> }
>
> It's only a minor cosmetic change, but it fixes this:
>
> Jan 31 11:06:20 gw02 pmacctd[27374]: #012eth5: (1391162780) 64905115
> packets received by filter
> Jan 31 11:06:20 gw02 pmacctd[27374]: eth5: (1391162780) 977534
> packets dropped by kernel
>
> The #012 obviously shouldn't be there. Fun fact:
>
> 1.1 (paolo 16-Jul-08): Log(LOG_NOTICE, "\n%s: (%u)
> %u packets received by filter\n", config.dev, now, ps.ps_recv);
>
> Seems it's been there since the very beginning, or at least the
> beginning of the CVS history ;-)
>
> Regards,
> Ruben Laban
>
> _______________________________________________
> pmacct-discussion mailing list
> http://www.pmacct.net/#mailinglists
_______________________________________________
pmacct-discussion mailing list
http://www.pmacct.net/#mailinglists
