Thanks for your work! I've just uploaded your changes in pmapper trunk version.
I think interesting improvements could be: - to refactor the js part to be more "pmapper 4 compliant" (extend PM.Plugin object, ...) - to avoid the AJAX call (all could be done in js with PM.ini.pluginsConfig.addbuttonstogroups values automatically loaded from XML configuration file) - to use more tags in the XML configuration file (instead of the old ini syntax) with something like that: <buttons> <button> <name>xxxx</name> <description>xxxxxxx</description> <image>xxxxxxxx</images> </button> <button> .... </button> ..... <buttons> (be careful if there is only 1 button declared!) Tell me if you are interested with those points and if I can help you, else I will do it later... Thanks again. Thomas Le 07/02/2011 12:38, Niccolo Rigacci a écrit : > On Mon, Feb 07, 2011 at 11:36:56AM +0100, Thomas RAFFIN wrote: >> I'm the author of this plugin. You're right: it doesn't work with >> p.mapper 4 and dev version. >> >> You can publish the new version if you have rights (or ask them to >> Armin), or send me a zip file and I will update it > I prefer if you have a look at it. If you think that it is ok, > please submit it. > > The main change I made is to avoid dynamic JavaScript code > generated with PHP. This is because the p.mapper 4 plugin code > does not allow $jsFiles to be PHP files. > > So the JavaScript init function must get the plugin configuration > via an AJAX call. > >> (feel free to update >> the doc: http://svn.pmapper.net/trac/wiki/PluginsToc). > If you upload the new code, I will have a look at it. > > Thank you very much. > ------------------------------------------------------------------------------ The modern datacenter depends on network connectivity to access resources and provide services. The best practices for maximizing a physical server's connectivity to a physical network are well understood - see how these rules translate into the virtual world? http://p.sf.net/sfu/oracle-sfdevnlfb _______________________________________________ pmapper-users mailing list pmapper-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/pmapper-users
