Hi Thomas,

Just checked, even with
<debugLevel>5</debugLevel>
the custom.js is still read before the plugins JS file

What compression function are you using and where?


On Mon, Jul 29, 2013 at 10:48 AM, Thomas RAFFIN <traf...@sirap.fr> wrote:

> Hi,
>
> Try to inactivate the compression (debug level = 5 I think) and tell us
> if the custom.js is before or after the plugins files please?
>
> AFAIK I don't use the same compression functions than in "standard"
> pmapper. So all js files are compressed in the same order than if they
> were included without compression. So the custom.js (and all other
> config/xxx/yyy.js files) is included AFTER all the plugins js files.
>
> Thomas
>
>
> Le 29/07/2013 09:53, Chris forum a écrit :
> > Ok I see.
> > Thanx for the tips, I am going to try adding a custom_plugin.js file.
> > I will also check if the plugins I modified are available as a class.
> >
> >
> > On Fri, Jul 26, 2013 at 7:04 PM, Armin Burger <armin.bur...@gmail.com
> >wrote:
> >
> >> The problem is that the custom.js file from your config directory is
> >> loaded before the plugin JS files, so they will not have any effect
> >>
> >> The cleanest way would be to separate the custom JS files from the
> >> default JS files. Currently there is a a single check and all are
> >> referenced at the same time. Since Thomas is probably using this
> >> functionality more often I leave it to him to decide if the main code
> >> should be changed accordingly.
> >>
> >> A fast workaround would be to use something like a "custom_plugin.js"
> >> and reference this in the classical way (<script type="text/javascript"
> >> ....>) in the "map_whatever.phtml" file's <head> section  just before
> >> the large <link... /> block.
> >>
> >> There is no golden way of modifying the plugin PHP code. If the plugin
> >> is written as a class you can create a new plugin that inherits from the
> >> default plugin class. Otherwise you will need to check modifications in
> >> the default plugin with you version, using whatever "diff"-like tool.
> >>
> >> armin
> >>
> >> On 07/26/2013 11:50 AM, Chris forum wrote:
> >>> Hi all,
> >>>
> >>> Now that Thomas has updated several plugins, I realise I shouldn't have
> >>> customized them in their own directories.
> >>>
> >>> I am now trying to put my changes back into custom.css and custom.js,
> in
> >>> order to not loose them at the next general update.
> >>>
> >>> I am first trying to do that with the Coordinates plugin where I have
> >> done
> >>> some modifications into coordinates.js.
> >>>
> >>> So now there is a modded
> >>> *$.extend(PM.Plugin,
> >>> {
> >>>       Coordinates:
> >>>       {*
> >>>
> >>> into my custom.js file, but it is not used/read by pmapper.
> >>> In order to have it taken into account, I have to delete that part in
> >>> coordinates.js
> >>>
> >>> Am I doing this correctly?
> >>> Is there a way to have custom.js 'taking the lead' over the plugins
> >> files?
> >>> What if a PHP file of a plugin needs to be modified?
> >>>
> >>> Cheers,
> >>> Chris
> >>>
> >>
> ------------------------------------------------------------------------------
> >>> See everything from the browser to the database with AppDynamics
> >>> Get end-to-end visibility with application monitoring from AppDynamics
> >>> Isolate bottlenecks and diagnose root cause in seconds.
> >>> Start your free trial of AppDynamics Pro today!
> >>>
> >>
> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
> >>> _______________________________________________
> >>> pmapper-users mailing list
> >>> pmapper-users@lists.sourceforge.net
> >>> https://lists.sourceforge.net/lists/listinfo/pmapper-users
> >>>
> >>
> >>
> >>
> ------------------------------------------------------------------------------
> >> See everything from the browser to the database with AppDynamics
> >> Get end-to-end visibility with application monitoring from AppDynamics
> >> Isolate bottlenecks and diagnose root cause in seconds.
> >> Start your free trial of AppDynamics Pro today!
> >>
> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
> >> _______________________________________________
> >> pmapper-users mailing list
> >> pmapper-users@lists.sourceforge.net
> >> https://lists.sourceforge.net/lists/listinfo/pmapper-users
> >>
> >
> ------------------------------------------------------------------------------
> > See everything from the browser to the database with AppDynamics
> > Get end-to-end visibility with application monitoring from AppDynamics
> > Isolate bottlenecks and diagnose root cause in seconds.
> > Start your free trial of AppDynamics Pro today!
> >
> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
> > _______________________________________________
> > pmapper-users mailing list
> > pmapper-users@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/pmapper-users
> >
> >
>
> --
>
>
> Thomas RAFFIN
> Chef de Projet Internet
> traf...@sirap.fr <mailto:traf...@sirap.fr>      Sirap <http://sirap.fr>
>       Tel
> : 04 75 72 84 10
> Fax : 04 75 70 07 98
> Rue Paul Louis Héroult - BP 253
> 26106 Romans cedex
>
>
> ------------------------------------------------------------------------------
> See everything from the browser to the database with AppDynamics
> Get end-to-end visibility with application monitoring from AppDynamics
> Isolate bottlenecks and diagnose root cause in seconds.
> Start your free trial of AppDynamics Pro today!
> http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
> _______________________________________________
> pmapper-users mailing list
> pmapper-users@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/pmapper-users
>
------------------------------------------------------------------------------
See everything from the browser to the database with AppDynamics
Get end-to-end visibility with application monitoring from AppDynamics
Isolate bottlenecks and diagnose root cause in seconds.
Start your free trial of AppDynamics Pro today!
http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk
_______________________________________________
pmapper-users mailing list
pmapper-users@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/pmapper-users

Reply via email to